linux-kernel - Re: [PATCH v1] virt: tdx-guest: Add Quote generation support using TSM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 11 Sep 2023 10:01:25 +0000
From:   "Huang, Kai" <kai.huang@...el.com>
To:     "sathyanarayanan.kuppuswamy@...ux.intel.com" 
        <sathyanarayanan.kuppuswamy@...ux.intel.com>,
        "Williams, Dan J" <dan.j.williams@...el.com>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "bp@...en8.de" <bp@...en8.de>,
        "dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>
CC:     "Yu, Guorui" <guorui.yu@...ux.alibaba.com>,
        "qinkun@...che.org" <qinkun@...che.org>,
        "wander@...hat.com" <wander@...hat.com>,
        "hpa@...or.com" <hpa@...or.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kirill.shutemov@...ux.intel.com" <kirill.shutemov@...ux.intel.com>,
        "Luck, Tony" <tony.luck@...el.com>,
        "dionnaglaze@...gle.com" <dionnaglaze@...gle.com>,
        "Aktas, Erdem" <erdemaktas@...gle.com>,
        "linux-coco@...ts.linux.dev" <linux-coco@...ts.linux.dev>,
        "x86@...nel.org" <x86@...nel.org>
Subject: Re: [PATCH v1] virt: tdx-guest: Add Quote generation support using
 TSM_REPORTS

On Sun, 2023-09-10 at 17:10 -0700, Kuppuswamy Sathyanarayanan wrote:
> 
> On 9/8/2023 9:19 AM, Dan Williams wrote:
> > > > Changes since previous version:
> > > > * Used ConfigFS interface instead of IOCTL interface.
> > > > * Used polling model for Quote generation and dropped the event notification IRQ support.
> > > Can you elaborate why the notification IRQ is dropped?
> > Because it was a pile of hacks and non-idiomatic complexity. It can come
> > back when / if driver code can treat it like a typical interrupt.
> 
> Currently, the VMM assumes that the vCPU that executes the TDG.VP.VMCALL
> <SetupEventNotifyInterrupt> hypercall as the target vCPU for event
> notification IRQ. To satisfy this assumption, the guest driver that uses
> this hypercall/IRQ had to include CPU/IRQ affinity related code changes. This
> adds unnecessary complication to the guest driver code without any real
> ARCH need or benefit. So we want to modify the GHCI ABI to let TD guest pass
> the target CPU as an argument. With this change, we can hide the IRQ related
> configuration in the IRQ chip code and let the guest driver treat the
> event notification IRQ as a regular interrupt.
> 

Sorry I missed some internal discussion.  Please feel free to ignore my
comments.