linux-kernel - Re: [PATCH 2/2] ARM: dts: at91: sama5d29_curiosity: Add device tree for sama5d29

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 11 Sep 2023 18:01:39 +0200
From:   Nicolas Ferre <nicolas.ferre@...rochip.com>
To:     claudiu beznea <claudiu.beznea@...on.dev>,
        <Mihai.Sain@...rochip.com>, <robh+dt@...nel.org>,
        <krzysztof.kozlowski+dt@...aro.org>, <conor+dt@...nel.org>,
        <alexandre.belloni@...tlin.com>, <andre.przywara@....com>,
        <Andrei.Simion@...rochip.com>, <Jerry.Ray@...rochip.com>,
        <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
CC:     <Cristian.Birsan@...rochip.com>
Subject: Re: [PATCH 2/2] ARM: dts: at91: sama5d29_curiosity: Add device tree
 for sama5d29_curiosity board

Hi Mihai, Claudiu,

First of all, thanks a lot for your help on this board DT, that's great!

On 03/08/2023 at 11:09, claudiu beznea wrote:
> Hi, Mihai,
> 
> On 02.08.2023 15:19,Mihai.Sain@...rochip.com  wrote:
>>> +&macb0 {
>>> +     pinctrl-names = "default";
>>> +     pinctrl-0 = <&pinctrl_macb0_default &pinctrl_macb0_phy_irq>;
>>> +     #address-cells = <1>;
>>> +     #size-cells = <0>;
>>> +     phy-mode = "rmii";
>>> +     status = "disabled";
>> Should any phy/mdio container be placed here? Also, any reason this node is disabled?
>> The board has no phy.
>> We will add external phy boards to macb interface and they will be present in dt-overlay.
>>
> Then remove the macb0 node from here and keep it in overlay.

What about choosing a phy and making it enabled by default. Because I 
doubt people will use this board without a phy under Linux, honestly.
Overlays would remove this "by default" node and add the replacing phy 
if hardware plugged-in is different.

By doing this we avoid having difficult situations where the most used 
phy with this board is disabled or non existant and that we absolutely 
need an overlay for such a basic thing as having Ethernet working 
out-of-the-box...

Just my $0.02, but it might simplify our life in the long run...

Best regards,
   Nicolas