linux-kernel - RE: [PATCH V6 3/7] cpufreq: amd-pstate: Enable amd-pstate preferred core supporting.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM4PR12MB6351B968FEB93729E2DACCF0F7F2A@DM4PR12MB6351.namprd12.prod.outlook.com>
Date:   Mon, 11 Sep 2023 05:42:52 +0000
From:   "Meng, Li (Jassmine)" <Li.Meng@....com>
To:     Peter Zijlstra <peterz@...radead.org>
CC:     "Rafael J . Wysocki" <rafael.j.wysocki@...el.com>,
        "Huang, Ray" <Ray.Huang@....com>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "x86@...nel.org" <x86@...nel.org>,
        "linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
        Shuah Khan <skhan@...uxfoundation.org>,
        "linux-kselftest@...r.kernel.org" <linux-kselftest@...r.kernel.org>,
        "Fontenot, Nathan" <Nathan.Fontenot@....com>,
        "Sharma, Deepak" <Deepak.Sharma@....com>,
        "Deucher, Alexander" <Alexander.Deucher@....com>,
        "Limonciello, Mario" <Mario.Limonciello@....com>,
        "Huang, Shimmer" <Shimmer.Huang@....com>,
        "Yuan, Perry" <Perry.Yuan@....com>,
        "Du, Xiaojian" <Xiaojian.Du@....com>,
        Viresh Kumar <viresh.kumar@...aro.org>,
        Borislav Petkov <bp@...en8.de>
Subject: RE: [PATCH V6 3/7] cpufreq: amd-pstate: Enable amd-pstate preferred
 core supporting.

[AMD Official Use Only - General]

Hi Peter:

> -----Original Message-----
> From: Peter Zijlstra <peterz@...radead.org>
> Sent: Sunday, September 10, 2023 1:40 AM
> To: Meng, Li (Jassmine) <Li.Meng@....com>
> Cc: Rafael J . Wysocki <rafael.j.wysocki@...el.com>; Huang, Ray
> <Ray.Huang@....com>; linux-pm@...r.kernel.org; linux-
> kernel@...r.kernel.org; x86@...nel.org; linux-acpi@...r.kernel.org; Shuah
> Khan <skhan@...uxfoundation.org>; linux-kselftest@...r.kernel.org;
> Fontenot, Nathan <Nathan.Fontenot@....com>; Sharma, Deepak
> <Deepak.Sharma@....com>; Deucher, Alexander
> <Alexander.Deucher@....com>; Limonciello, Mario
> <Mario.Limonciello@....com>; Huang, Shimmer
> <Shimmer.Huang@....com>; Yuan, Perry <Perry.Yuan@....com>; Du,
> Xiaojian <Xiaojian.Du@....com>; Viresh Kumar <viresh.kumar@...aro.org>;
> Borislav Petkov <bp@...en8.de>
> Subject: Re: [PATCH V6 3/7] cpufreq: amd-pstate: Enable amd-pstate
> preferred core supporting.
>
> Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
>
>
> On Fri, Sep 08, 2023 at 03:46:49PM +0800, Meng Li wrote:
> > +static void amd_pstate_init_prefcore(void) {
> > +     int cpu, ret;
> > +     u64 highest_perf;
> > +
> > +     if (!prefcore)
> > +             return;
> > +
> > +     for_each_online_cpu(cpu) {
> > +             ret = amd_pstate_get_highest_perf(cpu, &highest_perf);
> > +             if (ret)
> > +                     break;
> > +
> > +             sched_set_itmt_core_prio(highest_perf, cpu);
> > +
> > +             /* check if CPPC preferred core feature is enabled*/
> > +             if (highest_perf == AMD_PSTATE_MAX_CPPC_PERF) {
> > +                     pr_debug("AMD CPPC preferred core is unsupported!\n");
> > +                     hw_prefcore = false;
> > +                     prefcore = false;
> > +                     return;
> > +             }
> > +     }
> > +
> > +     /*
> > +      * This code can be run during CPU online under the
> > +      * CPU hotplug locks, so sched_set_amd_prefcore_support()
> > +      * cannot be called from here.  Queue up a work item
> > +      * to invoke it.
> > +      */
> > +     schedule_work(&sched_prefcore_work);
> > +}
>
> Brilliant, repost without addressing prior feedback..  :-(
[Meng, Li (Jassmine)]
I am very sorry that I did not receive your V5 review comments before sending V6 patches.
However, thank you very much for your review.
I will solve them one by one in the future V7 patches.
Thank you very much!