linux-kernel - Re: [PATCH] ASoC: dwc: Add Single DMA mode support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bf43b771-35e3-1b37-24f5-e21b2c34a415@linaro.org>
Date:   Mon, 11 Sep 2023 08:12:18 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Myunguk Kim <mwkim@...nchips.com>, alsa-devel@...a-project.org
Cc:     Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Maxim Kochetkov <fido_max@...ox.ru>,
        Xingyu Wu <xingyu.wu@...rfivetech.com>,
        Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
        Uw e Kleine-König <u.kleine-koenig@...gutronix.de>,
        linux-kernel@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Jose Abreu <joabreu@...opsys.com>, devicetree@...r.kernel.org
Subject: Re: [PATCH] ASoC: dwc: Add Single DMA mode support

On 11/09/2023 04:40, Myunguk Kim wrote:
> There is a SoC between dwc and DMA block (ie. PL330)
> that does not have a burst signal and supports only single.
> 
> So write not-support-burst property on dts, it support single DMA mode.
> 
> Signed-off-by: Myunguk Kim <mwkim@...nchips.com>
> ---
>  .../bindings/sound/snps,designware-i2s.yaml          |  3 +++

Bindings are always separate patch.

Please run scripts/checkpatch.pl and fix reported warnings. Some
warnings can be ignored, but the code here looks like it needs a fix.
Feel free to get in touch if the warning is not clear.

Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching.


>  include/sound/designware_i2s.h                       |  1 +
>  sound/soc/dwc/dwc-i2s.c                              | 12 ++++++++++--
>  3 files changed, 14 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/sound/snps,designware-i2s.yaml b/Documentation/devicetree/bindings/sound/snps,designware-i2s.yaml
> index a48d040b0a4f..43a46ba2a70c 100644
> --- a/Documentation/devicetree/bindings/sound/snps,designware-i2s.yaml
> +++ b/Documentation/devicetree/bindings/sound/snps,designware-i2s.yaml
> @@ -86,6 +86,9 @@ properties:
>        The phandle to System Register Controller syscon node and the I2S-rx(ADC)
>        enabled control offset and mask of SYS_SYSCONSAIF__SYSCFG register.
>  
> +  no-burst:
> +    description: Use single transaction only between DesignWare I2S and DMA IP.

This was not tested. Missing vendor prefix, type.

Anyway please provide some explanation why this cannot be deduced from
the compatible.


Best regards,
Krzysztof