linux-kernel - Re: [PATCH] ALSA: hda: cs35l56: Call pm_runtime_dont_use

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87sf7l6x42.wl-tiwai@suse.de>
Date:   Mon, 11 Sep 2023 08:29:49 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Richard Fitzgerald <rf@...nsource.cirrus.com>
Cc:     <tiwai@...e.com>, <alsa-devel@...a-project.org>,
        <patches@...nsource.cirrus.com>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ALSA: hda: cs35l56: Call pm_runtime_dont_use_autosuspend()

On Fri, 08 Sep 2023 12:12:23 +0200,
Richard Fitzgerald wrote:
> 
> Driver remove() must call pm_runtime_dont_use_autosuspend().
> 
> Drivers that call pm_runtime_use_autosuspend() must disable
> it in driver remove(). Unfortunately until recently this was
> only mentioned in 1 line in a 900+ line document so most
> people hadn't noticed this. It has only recently been added
> to the kerneldoc of pm_runtime_use_autosuspend().
> 
> Signed-off-by: Richard Fitzgerald <rf@...nsource.cirrus.com>
> Fixes: 2a930a6da8ec ("ALSA: hda/cs35l56: Add driver for Cirrus Logic CS35L56 amplifier")

Applied now.
The Fixes tag points to a non-existing ID, so I corrected in my side
to 73cfbfa9caea.


thanks,

Takashi

> ---
>  sound/pci/hda/cs35l56_hda.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/pci/hda/cs35l56_hda.c b/sound/pci/hda/cs35l56_hda.c
> index 76b9c685560b..9e4976bdb5e0 100644
> --- a/sound/pci/hda/cs35l56_hda.c
> +++ b/sound/pci/hda/cs35l56_hda.c
> @@ -1003,6 +1003,7 @@ void cs35l56_hda_remove(struct device *dev)
>  {
>  	struct cs35l56_hda *cs35l56 = dev_get_drvdata(dev);
>  
> +	pm_runtime_dont_use_autosuspend(cs35l56->base.dev);
>  	pm_runtime_get_sync(cs35l56->base.dev);
>  	pm_runtime_disable(cs35l56->base.dev);
>  
> -- 
> 2.30.2
>