linux-kernel - Re: [PATCH] dt-bindings: arm64: dts: mediatek: add description for mt8365-evk board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <649e89c3-343a-c00c-ae89-329833b38981@linaro.org>
Date:   Mon, 11 Sep 2023 09:06:55 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Macpaul Lin <macpaul.lin@...iatek.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>,
        Bernhard Rosenkränzer <bero@...libre.com>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org
Cc:     Bear Wang <bear.wang@...iatek.com>,
        Pablo Sun <pablo.sun@...iatek.com>,
        Macpaul Lin <macpaul@...il.com>
Subject: Re: [PATCH] dt-bindings: arm64: dts: mediatek: add description for
 mt8365-evk board

On 11/09/2023 08:34, Macpaul Lin wrote:
> On 9/11/23 14:09, Krzysztof Kozlowski wrote:
>> 	
>>
>> External email : Please do not click links or open attachments until you 
>> have verified the sender or the content.
>>
>> On 10/09/2023 14:07, Macpaul Lin wrote:
>>>
>>>
>>> On 9/10/23 17:09, Krzysztof Kozlowski wrote:
>>>>> +      - description: MediaTek Genio 350 Boards (Genio 350 EVK)
>>>>
>>>> That's a bit confusing. So all of the boards here will be Genio 350 EVK?
>>>> I don't get what is the point of this description.
>>>>
>>>>
>>>>> +        items:
>>>>>            - enum:
>>>>>                - mediatek,mt8365-evk
>>>>>            - const: mediatek,mt8365
>>>
>>> Thes boards with compatible 'mediatek,mt8365-evk' is indeed used by
>>
>> Boards?
> 
> I'm not sure if there will be more hardware version released to market.
> Current the p1v3 is the final version of mt8365-evk.

Then your code (enum) does not match description. The code is saying:
this is for multiple boards based on mt8365.

Your description is saying: this is only for 350 boards.

Now your email is saying: there is only one 350 board.

Three different versions. Sorry, I am confused.

> 
>>> Genio 350-EVK, which Baylibre helped to do upstream tasks. The only 
>>> production version of hardware will be available on the market. The 
>>> derived version of customer's hardware is not available yet.
>>>
>>> The separate patch for renaming mt8365-evk.dts file should be send next 
>>> week for aligning the naming rules.
>>
>> So the description is not correct.
>>
>> Anyway, this patch does not make much sense to me considering nothing
>> like this was merged. You just sent v5 doing the same!
> 
> 
> Sorry I'm confused now.
> These are independent patches.
> This patch is for SOC mt83'6'5 and board mt8365-evk, which is not relate 
> SOC mt83'9'5 and board mt8395-evk.

OK, I see my confusion. mt8365 and mt8395.

Still the description is not matching the code, at least to my limited
understanding of the description.


Best regards,
Krzysztof