linux-kernel - Re: [PATCH] x86: Fix build of UML with KASAN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f11475f922994b88f5adb14d23240716e16d5303.camel@axis.com>
Date:   Mon, 11 Sep 2023 07:26:00 +0000
From:   Vincent Whitchurch <Vincent.Whitchurch@...s.com>
To:     Vincent Whitchurch <Vincent.Whitchurch@...s.com>,
        "davidgow@...gle.com" <davidgow@...gle.com>,
        "x86@...nel.org" <x86@...nel.org>
CC:     "dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>,
        kernel <kernel@...s.com>,
        "rafael.j.wysocki@...el.com" <rafael.j.wysocki@...el.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "johannes@...solutions.net" <johannes@...solutions.net>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "linux-um@...ts.infradead.org" <linux-um@...ts.infradead.org>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "andreyknvl@...il.com" <andreyknvl@...il.com>,
        "anton.ivanov@...bridgegreys.com" <anton.ivanov@...bridgegreys.com>,
        "dvyukov@...gle.com" <dvyukov@...gle.com>,
        "richard@....at" <richard@....at>, "hpa@...or.com" <hpa@...or.com>,
        "peterz@...radead.org" <peterz@...radead.org>,
        "ryabinin.a.a@...il.com" <ryabinin.a.a@...il.com>,
        "frederic@...nel.org" <frederic@...nel.org>,
        "bp@...en8.de" <bp@...en8.de>,
        "glider@...gle.com" <glider@...gle.com>,
        "vincenzo.frascino@....com" <vincenzo.frascino@....com>,
        "kasan-dev@...glegroups.com" <kasan-dev@...glegroups.com>
Subject: Re: [PATCH] x86: Fix build of UML with KASAN

On Sat, 2023-06-10 at 16:34 +0800, David Gow wrote:
> On Fri, 9 Jun 2023 at 19:19, Vincent Whitchurch
> <vincent.whitchurch@...s.com> wrote:
> > 
> > Building UML with KASAN fails since commit 69d4c0d32186 ("entry, kasan,
> > x86: Disallow overriding mem*() functions") with the following errors:
> > 
> >  $ tools/testing/kunit/kunit.py run --kconfig_add CONFIG_KASAN=y
> >  ...
> >  ld: mm/kasan/shadow.o: in function `memset':
> >  shadow.c:(.text+0x40): multiple definition of `memset';
> >  arch/x86/lib/memset_64.o:(.noinstr.text+0x0): first defined here
> >  ld: mm/kasan/shadow.o: in function `memmove':
> >  shadow.c:(.text+0x90): multiple definition of `memmove';
> >  arch/x86/lib/memmove_64.o:(.noinstr.text+0x0): first defined here
> >  ld: mm/kasan/shadow.o: in function `memcpy':
> >  shadow.c:(.text+0x110): multiple definition of `memcpy';
> >  arch/x86/lib/memcpy_64.o:(.noinstr.text+0x0): first defined here
> > 
> > If I'm reading that commit right, the !GENERIC_ENTRY case is still
> > supposed to be allowed to override the mem*() functions, so use weak
> > aliases in that case.
> > 
> > Fixes: 69d4c0d32186 ("entry, kasan, x86: Disallow overriding mem*() functions")
> > Signed-off-by: Vincent Whitchurch <vincent.whitchurch@...s.com>
> > ---
> 
> Thanks: I stumbled into this the other day and ran out of time to debug it.
> 
> I've tested that it works here.
> 
> Tested-by: David Gow <davidgow@...gle.com>

Thanks.  Perhaps someone could pick this up?  It's been a few months,
and the build problem is still present on v6.6-rc1.