linux-kernel - Re: [PATCH] USB: add ignore remote wakeup quirk for one of Logitech's receivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9d2dff10-5a3b-b24a-c3d8-3c843891966d@redhat.com>
Date:   Mon, 11 Sep 2023 09:32:42 +0200
From:   Hans de Goede <hdegoede@...hat.com>
To:     Hamza Mahfooz <someguy@...ective-light.com>,
        linux-usb@...r.kernel.org
Cc:     stable@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Alan Stern <stern@...land.harvard.edu>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        Bastien Nocera <hadess@...ess.net>,
        Łukasz Bartosik <lb@...ihalf.com>,
        Nicolas Dumazet <ndumazet@...gle.com>,
        Jean-Francois Le Fillatre <jflf_kernel@....com>,
        Mark Pearson <mpearson-lenovo@...ebb.ca>,
        Hannu Hartikainen <hannu@...k.in>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] USB: add ignore remote wakeup quirk for one of Logitech's
 receivers

Hi Hamza,

On 9/10/23 18:37, Hamza Mahfooz wrote:
> This device causes the system to wake up from suspend, as soon as it
> enters it (even if the device attached to the receiver is powered off).
> So, ignore remote wakeup events from it.
> 
> Cc: stable@...r.kernel.org
> Signed-off-by: Hamza Mahfooz <someguy@...ective-light.com>
> ---
>  drivers/usb/core/quirks.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
> index 15e9bd180a1d..d2e2a2873f34 100644
> --- a/drivers/usb/core/quirks.c
> +++ b/drivers/usb/core/quirks.c
> @@ -264,6 +264,10 @@ static const struct usb_device_id usb_quirk_list[] = {
>  	/* Logitech Harmony 700-series */
>  	{ USB_DEVICE(0x046d, 0xc122), .driver_info = USB_QUIRK_DELAY_INIT },
>  
> +	/* Logitech lightspeed receiver (0xc547) */
> +	{ USB_DEVICE(0x046d, 0xc547), .driver_info =
> +			USB_QUIRK_IGNORE_REMOTE_WAKEUP },
> +
>  	/* Philips PSC805 audio device */
>  	{ USB_DEVICE(0x0471, 0x0155), .driver_info = USB_QUIRK_RESET_RESUME },
>  

If this is a lightspeed receiver then it really should be handled by
hid-logitech-dj.c unless this new receiver is using a new protocol ?

I wonder if adding it there also fixes the remote
wakeup issue (I doubt it fixes it but worth a try) ?

Regards,

Hans