linux-kernel - Re: [PATCH 2/2] ASoC: Adds support for TAS575x to the pcm512x driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZP8D3QMXX0TyVYs9@finisterre.sirena.org.uk>
Date:   Mon, 11 Sep 2023 13:11:09 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Joerg Schambacher <joerg.hifiberry@...il.com>
Cc:     a-krasser@...com, joerg@...iberry.com,
        Liam Girdwood <lgirdwood@...il.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>,
        Zhang Qilong <zhangqilong3@...wei.com>,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] ASoC: Adds support for TAS575x to the pcm512x driver

On Mon, Sep 11, 2023 at 01:59:46PM +0200, Joerg Schambacher wrote:
> Am 07.09.2023 um 17:28 hat Mark Brown geschrieben:
> > On Thu, Sep 07, 2023 at 06:21:50PM +0200, Joerg Schambacher wrote:

> > > But in the case of the TAS-devices we even then need the PLL to
> > > drive the AMP clocks.

> > That's definitely a separate quirk, and does sound like it should be
> > driven from the bias management or DAPM more than hw_params.

> Then it makes sense to use a DT-param 'force_pll_on' and even
> remove the compatible string fixes from the patch series.

If this device always needs the PLL then we should just figure it out
from the compatible rather than requiring a DT property which every
system with the device is going to need to set.

> Still, I think, this is the best part of the code to act on the PLL.
> Simply instead of checking 'do we need it or not' just let it run.
> What do you think?

It's probably fine.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)