[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZP7il27e9cExVWaL@titan>
Date: Mon, 11 Sep 2023 19:49:11 +1000
From: John Watts <contact@...kia.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: dri-devel@...ts.freedesktop.org,
Neil Armstrong <neil.armstrong@...aro.org>,
Sam Ravnborg <sam@...nborg.org>,
David Airlie <airlied@...il.com>,
Daniel Vetter <daniel@...ll.ch>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
Heiko Stuebner <heiko@...ech.de>,
Shawn Guo <shawnguo@...nel.org>,
Chris Morgan <macromorgan@...mail.com>,
Jagan Teki <jagan@...eble.ai>, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH 8/8] dt-bindings: display: panel: add Fascontek
FS035VG158 panel
Hello again,
On Mon, Sep 11, 2023 at 11:41:12AM +0200, Krzysztof Kozlowski wrote:
> > +maintainers:
> > + - John Watts <contact@...kia.org>
> > +
> > +allOf:
> > + - $ref: panel-common.yaml#
> > + - $ref: /schemas/spi/spi-peripheral-props.yaml#
> > +
> > +properties:
> > + compatible:
> > + const: fascontek,fs035vg158
> > +
> > + backlight: true
> > + port: true
> > + power-supply: true
> > + reg: true
> > + reset-gpios: true
>
> Why do you need all these 5? They are allowed by panel-common.
>
> > +
> > + spi-3wire: true
> > +
> > +required:
> > + - compatible
>
> Missing reg. Probably also port.
>
>
> > + - power-supply
> > + - reset-gpios
> > +
I have just copy pasted the other panel's yaml, so these issues apply
there too. Should I fix that panel's yaml up first then re-copy?
>
>
> Best regards,
> Krzysztof
>
John.
Powered by blists - more mailing lists