linux-kernel - Re: [PATCH v5] gpio: sim: don't fiddle with GPIOLIB private members

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMRc=Md++13y-h1xUADUkqshWFau0vqSvZoL2w27Rw1CM1MNUw@mail.gmail.com>
Date:   Mon, 11 Sep 2023 14:57:45 +0200
From:   Bartosz Golaszewski <brgl@...ev.pl>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Kent Gibson <warthog618@...il.com>, linux-gpio@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH v5] gpio: sim: don't fiddle with GPIOLIB private members

On Mon, Sep 11, 2023 at 2:56 PM Bartosz Golaszewski <brgl@...ev.pl> wrote:
>
> On Mon, Sep 11, 2023 at 2:54 PM Andy Shevchenko
> <andriy.shevchenko@...ux.intel.com> wrote:
> >
> > On Mon, Sep 11, 2023 at 01:07:40PM +0200, Bartosz Golaszewski wrote:
> > > From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> > >
> > > We access internals of struct gpio_device and struct gpio_desc because
> > > it's easier but it can actually be avoided and we're working towards a
> > > better encapsulation of GPIO data structures across the kernel so let's
> > > start at home.
> > >
> > > Instead of checking gpio_desc flags, let's just track the requests of
> > > GPIOs in the driver. We also already store the information about
> > > direction of simulated lines.
> > >
> > > For kobjects needed by sysfs callbacks: we can iterate over the children
> > > devices of the top-level platform device and compare their fwnodes
> > > against the one passed to the init function from probe.
> > >
> > > While at it: fix one line break and remove the untrue part about
> > > configfs callbacks using dev_get_drvdata() from a comment.
> >
> > (Just wondering if you used --patience)
> >
>
> I may have forgotten this one time. I need to add an alias.
>

Ah, I can do "git config --global diff.algorithm patience". Will use
it from now.

Bart

> Bart
>
> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> >
> > --
> > With Best Regards,
> > Andy Shevchenko
> >
> >