linux-kernel - RE: [PATCH v6 1/5] drm/amdgpu: Allocate coredump memory in a nonblocking way

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <MW4PR12MB5667BFFD978A330AD51E579CF2F2A@MW4PR12MB5667.namprd12.prod.outlook.com>
Date:   Mon, 11 Sep 2023 13:13:27 +0000
From:   "Sharma, Shashank" <Shashank.Sharma@....com>
To:     "Koenig, Christian" <Christian.Koenig@....com>,
        André Almeida <andrealmeid@...lia.com>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "amd-gfx@...ts.freedesktop.org" <amd-gfx@...ts.freedesktop.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     "kernel-dev@...lia.com" <kernel-dev@...lia.com>,
        "Deucher, Alexander" <Alexander.Deucher@....com>,
        "Pelloux-Prayer, Pierre-Eric" <Pierre-eric.Pelloux-prayer@....com>
Subject: RE: [PATCH v6 1/5] drm/amdgpu: Allocate coredump memory in a
 nonblocking way

[AMD Official Use Only - General]

Hey Christian,

Will do that.

Regards
Shashank

-----Original Message-----
From: Koenig, Christian <Christian.Koenig@....com>
Sent: Monday, September 11, 2023 1:15 PM
To: André Almeida <andrealmeid@...lia.com>; dri-devel@...ts.freedesktop.org; amd-gfx@...ts.freedesktop.org; linux-kernel@...r.kernel.org; Sharma, Shashank <Shashank.Sharma@....com>
Cc: kernel-dev@...lia.com; Deucher, Alexander <Alexander.Deucher@....com>; Pelloux-Prayer, Pierre-Eric <Pierre-eric.Pelloux-prayer@....com>
Subject: Re: [PATCH v6 1/5] drm/amdgpu: Allocate coredump memory in a nonblocking way

Am 11.09.23 um 05:00 schrieb André Almeida:
> During a GPU reset, a normal memory reclaim could block to reclaim
> memory. Giving that coredump is a best effort mechanism, it shouldn't
> disturb the reset path. Change its memory allocation flag to a
> nonblocking one.

Since it is a bug fix I've already pushed this one into our internal branch quite a while ago.

Shashank can you take care of picking up the remaining patches and pushing them to amd-staging-drm-next?

Thanks,
Christian.

>
> Signed-off-by: André Almeida <andrealmeid@...lia.com>
> Reviewed-by: Christian König <christian.koenig@....com>
> ---
> v5: no change
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index aa171db68639..bf4781551f88 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -4847,7 +4847,7 @@ static void amdgpu_reset_capture_coredumpm(struct amdgpu_device *adev)
>       struct drm_device *dev = adev_to_drm(adev);
>
>       ktime_get_ts64(&adev->reset_time);
> -     dev_coredumpm(dev->dev, THIS_MODULE, adev, 0, GFP_KERNEL,
> +     dev_coredumpm(dev->dev, THIS_MODULE, adev, 0, GFP_NOWAIT,
>                     amdgpu_devcoredump_read, amdgpu_devcoredump_free);
>   }
>   #endif