linux-kernel - Re: [PATCH AUTOSEL 4.19 4/6] PCI: dwc: Provide deinit callback for i.MX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZP7kVCxA0cRW94tc@duo.ucw.cz>
Date:   Mon, 11 Sep 2023 11:56:36 +0200
From:   Pavel Machek <pavel@...x.de>
To:     Sasha Levin <sashal@...nel.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Mark Brown <broonie@...nel.org>,
        Fabio Estevam <festevam@...il.com>,
        Lorenzo Pieralisi <lpieralisi@...nel.org>,
        Richard Zhu <hongxing.zhu@....com>,
        Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
        l.stach@...gutronix.de, kw@...ux.com, bhelgaas@...gle.com,
        shawnguo@...nel.org, linux-pci@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH AUTOSEL 4.19 4/6] PCI: dwc: Provide deinit callback for
 i.MX

Hi!

> From: Mark Brown <broonie@...nel.org>
> 
> [ Upstream commit fc8b24c28bec19fc0621d108b9ee81ddfdedb25a ]
> 
> The i.MX integration for the DesignWare PCI controller has a _host_exit()
> operation which undoes everything that the _host_init() operation does but
> does not wire this up as the host_deinit callback for the core, or call it
> in any path other than suspend. This means that if we ever unwind the
> initial probe of the device, for example because it fails, the regulator
> core complains that the regulators for the device were left enabled:

This is somehow not queued for 5.10. Mistake?

BR,
									Pavel
-- 
DENX Software Engineering GmbH,        Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)