linux-kernel - Re: [PATCH v2] media: cros-ec-cec: Add Constitution to the match table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <70260067-b12e-41e2-841c-8ee019a67513@xs4all.nl>
Date:   Mon, 11 Sep 2023 10:22:58 +0200
From:   Hans Verkuil <hverkuil-cisco@...all.nl>
To:     Stefan Adolfsson <sadolfsson@...omium.org>
Cc:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        Benson Leung <bleung@...omium.org>,
        Guenter Roeck <groeck@...omium.org>,
        Reka Norman <rekanorman@...omium.org>,
        linux-media@...r.kernel.org, chrome-platform@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] media: cros-ec-cec: Add Constitution to the match
 table

On 11/09/2023 10:19, Stefan Adolfsson wrote:
> From: Stefan Adolfsson <sadolfsson@...omium.org>
> 
> Constitution has two HDMI ports which support CEC:
>     Port B is EC port 0
>     Port A is EC port 1
> 
> This patch depends on "media: cros-ec-cec: Add Dibbi to the match
> table".
> 
> Signed-off-by: Stefan Adolfsson <sadolfsson@...omium.org>
> ---
> Changes in v2:
>  Use a NULL-terminated conns array for the match table entry
> 
>  drivers/media/cec/platform/cros-ec/cros-ec-cec.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/media/cec/platform/cros-ec/cros-ec-cec.c b/drivers/media/cec/platform/cros-ec/cros-ec-cec.c
> index 21361eff50ff..85431af65224 100644
> --- a/drivers/media/cec/platform/cros-ec/cros-ec-cec.c
> +++ b/drivers/media/cec/platform/cros-ec/cros-ec-cec.c
> @@ -296,6 +296,7 @@ struct cec_dmi_match {
>  
>  static const char *const fizz_conns[] = { "Port B", NULL };
>  static const char *const dibbi_conns[] = { "Port D", "Port B", NULL };
> +static const char *const constitution_conns[] = { "Port B", "Port A", NULL };
>  
>  static const struct cec_dmi_match cec_dmi_match_table[] = {
>  	/* Google Fizz */
> @@ -316,6 +317,8 @@ static const struct cec_dmi_match cec_dmi_match_table[] = {
>  	{ "Google", "Lisbon", "0000:00:02.0", fizz_conns },
>  	/* Google Dibbi */
>  	{ "Google", "Dibbi", "0000:00:02.0", dibbi_conns },
> +	/* Google Constitution */
> +	{ "Google", "Constitution", "0000:00:02.0", constitution_conns },
>  };
>  
>  static struct device *cros_ec_cec_find_hdmi_dev(struct device *dev,

I made that change myself when I merged your v1 patch. So I just mark this
v2 as Obsolete in patchwork.

Regards,

	Hans