linux-kernel - Re: [PATCH v13 06/22] x86/virt/tdx: Add SEAMCALL error printing for module initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <45ef20780a998ed5900fce8c69b5130c2cf72400.camel@intel.com>
Date:   Mon, 11 Sep 2023 12:07:37 +0000
From:   "Huang, Kai" <kai.huang@...el.com>
To:     "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
        "Hansen, Dave" <dave.hansen@...el.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     "Raj, Ashok" <ashok.raj@...el.com>,
        "Luck, Tony" <tony.luck@...el.com>,
        "david@...hat.com" <david@...hat.com>,
        "bagasdotme@...il.com" <bagasdotme@...il.com>,
        "ak@...ux.intel.com" <ak@...ux.intel.com>,
        "Wysocki, Rafael J" <rafael.j.wysocki@...el.com>,
        "kirill.shutemov@...ux.intel.com" <kirill.shutemov@...ux.intel.com>,
        "Chatre, Reinette" <reinette.chatre@...el.com>,
        "Christopherson,, Sean" <seanjc@...gle.com>,
        "pbonzini@...hat.com" <pbonzini@...hat.com>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "Yamahata, Isaku" <isaku.yamahata@...el.com>,
        "nik.borisov@...e.com" <nik.borisov@...e.com>,
        "hpa@...or.com" <hpa@...or.com>,
        "peterz@...radead.org" <peterz@...radead.org>,
        "Shahar, Sagi" <sagis@...gle.com>,
        "imammedo@...hat.com" <imammedo@...hat.com>,
        "bp@...en8.de" <bp@...en8.de>, "Gao, Chao" <chao.gao@...el.com>,
        "Brown, Len" <len.brown@...el.com>,
        "sathyanarayanan.kuppuswamy@...ux.intel.com" 
        <sathyanarayanan.kuppuswamy@...ux.intel.com>,
        "Huang, Ying" <ying.huang@...el.com>,
        "Williams, Dan J" <dan.j.williams@...el.com>,
        "x86@...nel.org" <x86@...nel.org>
Subject: Re: [PATCH v13 06/22] x86/virt/tdx: Add SEAMCALL error printing for
 module initialization

On Fri, 2023-09-08 at 09:31 -0700, Dave Hansen wrote:
> On 8/25/23 05:14, Kai Huang wrote:
> > +#define SEAMCALL_PRERR(__seamcall_func, __fn, __args, __seamcall_err_func)	\
> > +({										\
> > +	u64 ___sret = __SEAMCALL_PRERR(__seamcall_func, __fn, __args,		\
> > +			__seamcall_err_func, pr_err);				\
> > +	int ___ret;								\
> > +										\
> > +	switch (___sret) {							\
> > +	case TDX_SUCCESS:							\
> > +		___ret = 0;							\
> > +		break;								\
> > +	case TDX_SEAMCALL_VMFAILINVALID:					\
> > +		pr_err("SEAMCALL failed: TDX module not loaded.\n");		\
> > +		___ret = -ENODEV;						\
> > +		break;								\
> > +	case TDX_SEAMCALL_GP:							\
> > +		pr_err("SEAMCALL failed: TDX disabled by BIOS.\n");		\
> > +		___ret = -EOPNOTSUPP;						\
> > +		break;								\
> > +	case TDX_SEAMCALL_UD:							\
> > +		pr_err("SEAMCALL failed: CPU not in VMX operation.\n");		\
> > +		___ret = -EACCES;						\
> > +		break;								\
> > +	default:								\
> > +		___ret = -EIO;							\
> > +	}									\
> > +	___ret;									\
> > +})
> 
> I have no clue where all of this came from or why it is necessary or why
> it has to be macros.  I'm just utterly confused.
> 
> I was really hoping to be able to run through this set and get it ready
> to be merged.  But it seems to still be seeing a *LOT* of change.
> Should I wait another few weeks for this to settle down again?

Those changes are due to SEAMCALL API change from the TDCALL/VMCALL/SEAMCALL
assembly change patchset.  I'll work internally to make this stable asap (I
tried before but was suggested to sent out to community for feedback).

Also I would appreciate if you could take a look at patch 18/19 (which are
separated small patches for better review) and patch 20 (reset PAMT in kexec).

Thanks in advance!