linux-kernel - Re: [PATCH] mtd: cs42l43: use modern PM macro helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f03eac55-04ac-b99f-f545-ef8bb7e80f42@opensource.cirrus.com>
Date:   Mon, 11 Sep 2023 14:04:43 +0100
From:   Richard Fitzgerald <rf@...nsource.cirrus.com>
To:     Arnd Bergmann <arnd@...nel.org>,
        James Schulman <james.schulman@...rus.com>,
        David Rhodes <david.rhodes@...rus.com>,
        "Lee Jones" <lee@...nel.org>,
        Charles Keepax <ckeepax@...nsource.cirrus.com>
CC:     Arnd Bergmann <arnd@...db.de>, <alsa-devel@...a-project.org>,
        <patches@...nsource.cirrus.com>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mtd: cs42l43: use modern PM macro helpers

On 11/09/2023 12:16, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> The old SET_SYSTEM_SLEEP_PM_OPS/SET_RUNTIME_PM_OPS macros required enclosing
> the function definitions in an #ifdef or marking them __maybe_unused:
> 
<SNIP>

>   
>   EXPORT_NS_GPL_DEV_PM_OPS(cs42l43_pm_ops, MFD_CS42L43) = {
> -	SET_SYSTEM_SLEEP_PM_OPS(cs42l43_suspend, cs42l43_resume)
> -	SET_RUNTIME_PM_OPS(cs42l43_runtime_suspend, cs42l43_runtime_resume, NULL)
> +	SYSTEM_SLEEP_PM_OPS(cs42l43_suspend, cs42l43_resume)
> +	RUNTIME_PM_OPS(cs42l43_runtime_suspend, cs42l43_runtime_resume, NULL)
>   };

Charles already sent a patch for this. We're waiting for Lee to merge it.
https://lore.kernel.org/all/20230822114914.340359-1-ckeepax@opensource.cirrus.com/