linux-kernel - Re: [PATCH v3 2/9] arm64: dts: qcom: apq8016-sbc: Add overlay for usb host mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ca518c28-1375-9eaf-ffd4-bedf06810000@collabora.com>
Date:   Mon, 11 Sep 2023 18:08:57 +0530
From:   Vignesh Raman <vignesh.raman@...labora.com>
To:     Konrad Dybcio <konrad.dybcio@...aro.org>,
        dri-devel@...ts.freedesktop.org
Cc:     helen.koike@...labora.com, guilherme.gallo@...labora.com,
        sergi.blanch.torne@...labora.com, david.heidelberg@...labora.com,
        daniels@...labora.com, gustavo.padovan@...labora.com,
        angelogioacchino.delregno@...labora.com, emma@...olt.net,
        robclark@...edesktop.org, robdclark@...gle.com, anholt@...gle.com,
        robdclark@...il.com, airlied@...il.com, daniel@...ll.ch,
        jani.nikula@...ux.intel.com, mripard@...nel.org,
        dmitry.baryshkov@...aro.org, matthias.bgg@...il.com,
        agross@...nel.org, andersson@...nel.org, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-mediatek@...ts.infradead.org,
        virtualization@...ts.linux-foundation.org,
        linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH v3 2/9] arm64: dts: qcom: apq8016-sbc: Add overlay for usb
 host mode

Hi Konrad,

On 11/09/23 17:20, Konrad Dybcio wrote:
> On 8.09.2023 17:22, Vignesh Raman wrote:
>> Due to the presence of the fastboot micro cable in the CI farm,
>> it causes the hardware to remain in gadget mode instead of host mode.
>> So it doesn't find the network, which results in failure to mount root
>> fs via NFS.
>>
>> Add an overlay dtso file that sets the dr_mode to host, allowing
>> the USB controllers to work in host mode. This dtso file will be used
>> in drm-ci, mesa-ci.
>>
>> Overlay DT file uses the sugar syntax [suggested by Dmitry Baryshkov and Maxime Ripard]
>>
>> Suggested-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
>> Suggested-by: Maxime Ripard <mripard@...nel.org>
>> Signed-off-by: Helen Koike <helen.koike@...labora.com>
>> Signed-off-by: David Heidelberg <david.heidelberg@...labora.com>
>> Signed-off-by: Vignesh Raman <vignesh.raman@...labora.com>
>> ---
> For such a small change, maybe you can just use sed in your
> scripts to alter this?

This was the initial idea 
https://patchwork.kernel.org/project/linux-mediatek/patch/20230825122435.316272-3-vignesh.raman@collabora.com/

Since there was a review comment that CI should not make changes to the 
source tree before building, we went with DT overlay.

Regards,
Vignesh