linux-kernel - Re: [PATCH] slab: drop unneeded NULL-pointer check in kfree auto cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMRc=McXAmOhN-vqCjz72uPB4V0Srw2czWYiSpVH7mBfBCQJpg@mail.gmail.com>
Date:   Tue, 12 Sep 2023 13:26:05 +0200
From:   Bartosz Golaszewski <brgl@...ev.pl>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     Christoph Lameter <cl@...ux.com>,
        Pekka Enberg <penberg@...nel.org>,
        David Rientjes <rientjes@...gle.com>,
        Joonsoo Kim <iamjoonsoo.kim@....com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Vlastimil Babka <vbabka@...e.cz>,
        Roman Gushchin <roman.gushchin@...ux.dev>,
        Hyeonggon Yoo <42.hyeyoo@...il.com>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org,
        Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH] slab: drop unneeded NULL-pointer check in kfree auto cleanup

On Tue, Sep 12, 2023 at 12:43 PM Peter Zijlstra <peterz@...radead.org> wrote:
>
> On Tue, Sep 12, 2023 at 10:26:43AM +0200, Bartosz Golaszewski wrote:
> > From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> >
> > kfree() already accepts and silently ignores NULL-pointers, there's no
> > need to check it when running the auto cleanup routine.
>
> There is, because now the compiler can't help you anymore. Also see:
>
>   https://lkml.kernel.org/r/169451499208.27769.5856056754166699857.tip-bot2@tip-bot2

Makes sense, thanks!

Bart