linux-kernel - Re: [PATCH v13 1/7] irqchip/gic-v3: Enable support for SGIs to act as NMIs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 12 Sep 2023 13:43:44 +0100
From:   Marc Zyngier <maz@...nel.org>
To:     Douglas Anderson <dianders@...omium.org>
Cc:     Mark Rutland <mark.rutland@....com>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will@...nel.org>,
        Sumit Garg <sumit.garg@...aro.org>,
        Daniel Thompson <daniel.thompson@...aro.org>,
        linux-arm-kernel@...ts.infradead.org,
        "Rafael J . Wysocki" <rafael.j.wysocki@...el.com>,
        Lecopzer Chen <lecopzer.chen@...iatek.com>,
        Chen-Yu Tsai <wens@...e.org>,
        Tomohiro Misono <misono.tomohiro@...itsu.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Masayoshi Mizuma <msys.mizuma@...il.com>,
        Stephane Eranian <eranian@...gle.com>,
        Ard Biesheuvel <ardb@...nel.org>,
        kgdb-bugreport@...ts.sourceforge.net,
        Stephen Boyd <swboyd@...omium.org>,
        linux-perf-users@...r.kernel.org,
        Thomas Gleixner <tglx@...utronix.de>, ito-yuichi@...itsu.com,
        Chen-Yu Tsai <wenst@...omium.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v13 1/7] irqchip/gic-v3: Enable support for SGIs to act as NMIs

On Wed, 06 Sep 2023 17:02:56 +0100,
Douglas Anderson <dianders@...omium.org> wrote:
> 
> As of commit 6abbd6988971 ("irqchip/gic, gic-v3: Make SGIs use
> handle_percpu_devid_irq()") SGIs are treated the same as PPIs/EPPIs
> and use handle_percpu_devid_irq() by default. Unfortunately,
> handle_percpu_devid_irq() isn't NMI safe, and so to run in an NMI
> context those should use handle_percpu_devid_fasteoi_nmi().
> 
> In order to accomplish this, we just have to make room for SGIs in the
> array of refcounts that keeps track of which interrupts are set as
> NMI. We also rename the array and create a new indexing scheme that
> accounts for SGIs.
> 
> Also, enable NMI support prior to gic_smp_init() as allocation of SGIs
> as IRQs/NMIs happen as part of this routine.
> 
> Co-developed-by: Sumit Garg <sumit.garg@...aro.org>
> Signed-off-by: Sumit Garg <sumit.garg@...aro.org>
> Acked-by: Mark Rutland <mark.rutland@....com>
> Tested-by: Chen-Yu Tsai <wenst@...omium.org>
> Signed-off-by: Douglas Anderson <dianders@...omium.org>

Acked-by: Marc Zyngier <maz@...nel.org>

	M.

-- 
Without deviation from the norm, progress is not possible.