[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <07a569b9-e691-64ea-dd65-3b49842af33d@linaro.org>
Date: Tue, 12 Sep 2023 14:57:45 +0200
From: Daniel Lezcano <daniel.lezcano@...aro.org>
To: Frank Wunderlich <frank-w@...lic-files.de>
Cc: Markus Schneider-Pargmann <msp@...libre.com>,
Fabien Parent <fparent@...libre.com>,
Amjad Ouled-Ameur <aouledameur@...libre.com>,
Daniel Golle <daniel@...rotopia.org>,
linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org,
Alex Riabchenko <d3adme4t@...il.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@...labora.com>,
Matthias Brugger <matthias.bgg@...il.com>
Subject: Re: Aw: regression with 33140e668b10 thermal/drivers/mediatek:
Control buffer enablement tweaks
Hi Frank,
thanks for reporting and investigating the issue.
On 31/08/2023 15:34, Frank Wunderlich wrote:
> Hi,
>
> looked a bit deeper into it and it looks like i only need to add the fields in the mtk_thermal_data struct
>
> --- a/drivers/thermal/mediatek/auxadc_thermal.c
> +++ b/drivers/thermal/mediatek/auxadc_thermal.c
> @@ -690,6 +690,9 @@ static const struct mtk_thermal_data mt7986_thermal_data = {
> .adcpnp = mt7986_adcpnp,
> .sensor_mux_values = mt7986_mux_values,
> .version = MTK_THERMAL_V3,
> + .apmixed_buffer_ctl_reg = APMIXED_SYS_TS_CON1,
> + .apmixed_buffer_ctl_mask = GENMASK(31, 6) | BIT(3),
> + .apmixed_buffer_ctl_set = BIT(0),
> };
>
> in my quick test the temprature can be read again and i'm near room temperature...i though it was a bit higher before, but as far as i understand the code, the values were fixed before and only made it configurable.
>
> if someone can confirm that i'm right, i can send official patch.
At the first glance, it seems the proposed change is correct and could
be proposed as a hot fix.
However, the conditions with the version and the apmixed_buffer_ctl_reg
looks a bit fuzzy.
Markus, can you revisit this part of code and consolidate the
configurable approach ?
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
Powered by blists - more mailing lists