linux-kernel - Re: [PATCH 1/2] ASoC: pcm512x: Adds bindings for TAS575x devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230912151535.GA812148-robh@kernel.org>
Date:   Tue, 12 Sep 2023 10:15:35 -0500
From:   Rob Herring <robh@...nel.org>
To:     Joerg Schambacher <joerg.hifiberry@...il.com>
Cc:     a-krasser@...com, joerg@...iberry.com,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        alsa-devel@...a-project.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] ASoC: pcm512x: Adds bindings for TAS575x devices

On Thu, Sep 07, 2023 at 06:08:51PM +0200, Joerg Schambacher wrote:
> The TAS5754/6 power amplifiers use the same pcm512x driver with
> only minor restictions described in the bindings document.
> 
> Signed-off-by: Joerg Schambacher <joerg.hifiberry@...il.com>
> ---
>  .../devicetree/bindings/sound/pcm512x.txt     | 22 +++++++++++++++----
>  1 file changed, 18 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/sound/pcm512x.txt b/Documentation/devicetree/bindings/sound/pcm512x.txt
> index 3aae3b41bd8e..b16cd0463695 100644
> --- a/Documentation/devicetree/bindings/sound/pcm512x.txt
> +++ b/Documentation/devicetree/bindings/sound/pcm512x.txt
> @@ -1,12 +1,12 @@
> -PCM512x audio CODECs
> +PCM512x and TAS575x audio CODECs/amplifiers
>  
>  These devices support both I2C and SPI (configured with pin strapping
> -on the board).
> +on the board). The TAS575x devices only support I2C.
>  
>  Required properties:
>  
> -  - compatible : One of "ti,pcm5121", "ti,pcm5122", "ti,pcm5141" or
> -                 "ti,pcm5142"
> +  - compatible : One of "ti,pcm5121", "ti,pcm5122", "ti,pcm5141",
> +                 "ti,pcm5142", "ti,tas5754" or "ti,tas5756"
>  
>    - reg : the I2C address of the device for I2C, the chip select
>            number for SPI.
> @@ -25,6 +25,7 @@ Optional properties:
>      through <6>.  The device will be configured for clock input on the
>      given pll-in pin and PLL output on the given pll-out pin.  An
>      external connection from the pll-out pin to the SCLK pin is assumed.
> +    Caution: the TAS-desvices only support gpios 1,2 and 3
>  
>  Examples:
>  
> @@ -50,3 +51,16 @@ Examples:
>  		pll-in = <3>;
>  		pll-out = <6>;
>  	};
> +
> +	tas5756: tas5756@4f {
> +		compatible = "ti,tas5756";

Is there anything new here? Just a different compatible doesn't justify 
another example.

With that dropped,

Reviewed-by: Rob Herring <robh@...nel.org>