linux-kernel - Re: [PATCH] of: dynamic: Fix potential memory leak in of_changeset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdX9xi5S3LGLoO7+pyAmX=h5_0KFQ5xfFrC7_Z1GV1TGfA@mail.gmail.com>
Date:   Tue, 12 Sep 2023 17:55:11 +0200
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Rob Herring <robh@...nel.org>
Cc:     Dan Carpenter <dan.carpenter@...aro.org>,
        kbuild test robot <lkp@...el.com>,
        Frank Rowand <frowand.list@...il.com>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] of: dynamic: Fix potential memory leak in of_changeset_action()

Hi Rob,

On Tue, Sep 12, 2023 at 5:32 PM Rob Herring <robh@...nel.org> wrote:
> On Fri, Sep 8, 2023 at 11:14 AM Dan Carpenter <dan.carpenter@...aro.org> wrote:
> > On Fri, Sep 08, 2023 at 05:34:53PM +0200, Geert Uytterhoeven wrote:
> > > > > Fixes: 914d9d831e61 ("of: dynamic: Refactor action prints to not use "%pOF" inside devtree_lock")
> > > > > Reported-by: kernel test robot <lkp@...el.com>
> > > > > Closes: https://lore.kernel.org/r/202309011059.EOdr4im9-lkp@intel.com/
> > > >
> > > > Despite what that says, it was never reported to me. IOW, the added TO
> > > > and CC lines don't seem to have any effect.
> > >
> > > The copy I received did list you in the "To"-header, though.
>
> Are you sure that's the header and not in the body?

Yes:

    Date: Thu, 7 Sep 2023 13:52:48 +0300
    From: Dan Carpenter <dan.carpenter@...aro.org>
    To: oe-kbuild@...ts.linux.dev, Rob Herring <robh@...nel.org>
    Cc: lkp@...el.com, oe-kbuild-all@...ts.linux.dev,
linux-kernel@...r.kernel.org, Geert Uytterhoeven
<geert+renesas@...der.be>
    Subject: drivers/of/dynamic.c:935 of_changeset_action() warn:
possible memory leak of 'ce'
    Message-ID: <eaa86211-436d-445b-80bd-84cea5745b5a@...am.mountain>

> > > Fall-out of the issues seen with Gmail lately?
> > > I do miss lots of email, too :-(
> >
> > My gmail account dropped a whole lot of mail too in the last week of
> > August.  I was out of office that week so I didn't investigate.  I was
> > assuming it was an issue with vger...
>
> I don't think it's related to those issues. If I search lore including
> my email[1], then it doesn't find it either. Lore only has it in
> oe-kbuild. Not LKML or oe-kbuild-all. It really just looks like the
> git-send-email style of extracting emails from tags in the body is not
> happening.

Oh, looks like there were two emails, one from lkp, and one from Dan:
https://lore.kernel.org/all/eaa86211-436d-445b-80bd-84cea5745b5a@kadam.mountain

I was referring to the one from Dan, which is not the one in Closes:.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds