linux-kernel - Re: [PATCH v1] ALSA: hda/tas2781: Support ACPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202309122358.aEcJnIUJ-lkp@intel.com>
Date:   Wed, 13 Sep 2023 00:11:20 +0800
From:   kernel test robot <lkp@...el.com>
To:     Shenghao Ding <shenghao-ding@...com>, tiwai@...e.de
Cc:     llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
        robh+dt@...nel.org, andriy.shevchenko@...ux.intel.com,
        lgirdwood@...il.com, perex@...ex.cz,
        pierre-louis.bossart@...ux.intel.com, kevin-lu@...com,
        13916275206@....com, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org, liam.r.girdwood@...el.com,
        mengdong.lin@...el.com, baojun.xu@...com,
        thomas.gfeller@...rop.com, peeyush@...com, navada@...com,
        broonie@...nel.org, gentuser@...il.com,
        Shenghao Ding <shenghao-ding@...com>
Subject: Re: [PATCH v1] ALSA: hda/tas2781: Support ACPI_ID both TXNW2781 and
 TIAS2781

Hi Shenghao,

kernel test robot noticed the following build warnings:

[auto build test WARNING on tiwai-sound/for-next]
[also build test WARNING on tiwai-sound/for-linus linus/master v6.6-rc1 next-20230912]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Shenghao-Ding/ALSA-hda-tas2781-Support-ACPI_ID-both-TXNW2781-and-TIAS2781/20230910-153010
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next
patch link:    https://lore.kernel.org/r/20230910072704.1359-1-shenghao-ding%40ti.com
patch subject: [PATCH v1] ALSA: hda/tas2781: Support ACPI_ID both TXNW2781 and TIAS2781
config: i386-buildonly-randconfig-003-20230912 (https://download.01.org/0day-ci/archive/20230912/202309122358.aEcJnIUJ-lkp@intel.com/config)
compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230912/202309122358.aEcJnIUJ-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202309122358.aEcJnIUJ-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> sound/pci/hda/tas2781_hda_i2c.c:665:24: warning: variable 'tas_priv' is uninitialized when used here [-Wuninitialized]
                   return dev_err_probe(tas_priv->dev, -ENODEV,
                                        ^~~~~~~~
   sound/pci/hda/tas2781_hda_i2c.c:656:33: note: initialize the variable 'tas_priv' to silence this warning
           struct tasdevice_priv *tas_priv;
                                          ^
                                           = NULL
   1 warning generated.


vim +/tas_priv +665 sound/pci/hda/tas2781_hda_i2c.c

   653	
   654	static int tas2781_hda_i2c_probe(struct i2c_client *clt)
   655	{
   656		struct tasdevice_priv *tas_priv;
   657		int ret, i;
   658	
   659		/* Check TIAS2781 or TXNW2781 */
   660		for (i = 0; i < ARRAY_SIZE(tas2781_acpi_hda_match); i++)
   661			if (strstr(dev_name(&clt->dev), tas2781_acpi_hda_match[i].id))
   662				break;
   663	
   664		if (i == ARRAY_SIZE(tas2781_acpi_hda_match))
 > 665			return dev_err_probe(tas_priv->dev, -ENODEV,
   666				"Device not available\n");
   667	
   668		tas_priv = tasdevice_kzalloc(clt);
   669		if (!tas_priv)
   670			return -ENOMEM;
   671	
   672		tas_priv->irq_info.irq = clt->irq;
   673		ret = tas2781_read_acpi(tas_priv, tas2781_acpi_hda_match[i].id);
   674		if (ret)
   675			return dev_err_probe(tas_priv->dev, ret,
   676				"Platform not supported\n");
   677	
   678		ret = tasdevice_init(tas_priv);
   679		if (ret)
   680			goto err;
   681	
   682		pm_runtime_set_autosuspend_delay(tas_priv->dev, 3000);
   683		pm_runtime_use_autosuspend(tas_priv->dev);
   684		pm_runtime_mark_last_busy(tas_priv->dev);
   685		pm_runtime_set_active(tas_priv->dev);
   686		pm_runtime_get_noresume(tas_priv->dev);
   687		pm_runtime_enable(tas_priv->dev);
   688	
   689		pm_runtime_put_autosuspend(tas_priv->dev);
   690	
   691		ret = component_add(tas_priv->dev, &tas2781_hda_comp_ops);
   692		if (ret) {
   693			dev_err(tas_priv->dev, "Register component failed: %d\n", ret);
   694			pm_runtime_disable(tas_priv->dev);
   695			goto err;
   696		}
   697	
   698		tas2781_reset(tas_priv);
   699	err:
   700		if (ret)
   701			tas2781_hda_remove(&clt->dev);
   702		return ret;
   703	}
   704	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki