linux-kernel - Re: [PATCH v9 0/9] x86/resctrl: Miscellaneous resctrl features

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1700871a-882a-b7c4-a33d-7466d92f728b@amd.com>
Date:   Tue, 12 Sep 2023 11:53:05 -0500
From:   "Moger, Babu" <babu.moger@....com>
To:     Reinette Chatre <reinette.chatre@...el.com>, corbet@....net,
        tglx@...utronix.de, mingo@...hat.com, bp@...en8.de
Cc:     fenghua.yu@...el.com, dave.hansen@...ux.intel.com, x86@...nel.org,
        hpa@...or.com, paulmck@...nel.org, akpm@...ux-foundation.org,
        quic_neeraju@...cinc.com, rdunlap@...radead.org,
        damien.lemoal@...nsource.wdc.com, songmuchun@...edance.com,
        peterz@...radead.org, jpoimboe@...nel.org, pbonzini@...hat.com,
        chang.seok.bae@...el.com, pawan.kumar.gupta@...ux.intel.com,
        jmattson@...gle.com, daniel.sneddon@...ux.intel.com,
        sandipan.das@....com, tony.luck@...el.com, james.morse@....com,
        linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
        bagasdotme@...il.com, eranian@...gle.com,
        christophe.leroy@...roup.eu, jarkko@...nel.org,
        adrian.hunter@...el.com, quic_jiles@...cinc.com,
        peternewman@...gle.com
Subject: Re: [PATCH v9 0/9] x86/resctrl: Miscellaneous resctrl features

Hi Reinette,

On 9/11/23 18:08, Reinette Chatre wrote:
> Hi Babu,
> 
> On 9/7/2023 4:51 PM, Babu Moger wrote:
>> These series adds support few minor features.
>> 1. Support assigning multiple tasks to control/mon groups in one command.
>> 2. Add debug mount option for resctrl interface.
>> 3. Add RMID and CLOSID in resctrl interface when mounted with debug option.
>> 4. Moves the default control group creation during the mount instead of during init.
>> 5. While doing these above changes, found that rftype flags needed some cleanup.
>>    They were named inconsistently. Re-arranged them much more cleanly now and added
>>    few comments. Hope it can help future additions.
>> ---
>> v9:
>>    Changes since v8:
>>    Split the RMID display in a separate patch. RMID is a special case here as it
>>    should be printed only if monitoring is enabled.
>>    Made rdtgroup_setup_root and rdtgroup_destroy_root as static functions.
>>    Added code to print pid_str in case of task parse error.
> 
> fyi ... I found this version difficult to review. The cover letter contained this
> high level list of changes while some patches were changed without getting a mention
> here nor in patch-specific list of changes. I ended up needing to do a diff with the
> previous version to get an idea of what actually changed.

Yes. My bad. Should have listed the changes on each patch. Sure. Will do
next time.
thanks
Babu