linux-kernel - Re: [PATCH v3 6/9] arm64: defconfig: Enable DA9211 regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3f1f1679-2d0a-d501-da9c-cb38088acef2@collabora.com>
Date:   Tue, 12 Sep 2023 13:56:49 -0300
From:   Helen Koike <helen.koike@...labora.com>
To:     Vignesh Raman <vignesh.raman@...labora.com>,
        dri-devel@...ts.freedesktop.org
Cc:     guilherme.gallo@...labora.com, sergi.blanch.torne@...labora.com,
        david.heidelberg@...labora.com, daniels@...labora.com,
        gustavo.padovan@...labora.com,
        angelogioacchino.delregno@...labora.com, emma@...olt.net,
        robclark@...edesktop.org, robdclark@...gle.com, anholt@...gle.com,
        robdclark@...il.com, airlied@...il.com, daniel@...ll.ch,
        jani.nikula@...ux.intel.com, mripard@...nel.org,
        dmitry.baryshkov@...aro.org, matthias.bgg@...il.com,
        agross@...nel.org, andersson@...nel.org, konrad.dybcio@...aro.org,
        robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        conor+dt@...nel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-mediatek@...ts.infradead.org,
        virtualization@...ts.linux-foundation.org,
        linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH v3 6/9] arm64: defconfig: Enable DA9211 regulator



On 08/09/2023 12:22, Vignesh Raman wrote:
> Mediatek mt8173 board fails to boot with DA9211 regulator disabled.
> Enabling CONFIG_REGULATOR_DA9211=y in drm-ci fixes the issue.
> 
> So enable it in the defconfig since kernel-ci also requires it.

tbh, =m doesn't solve for mesa-ci (since we don't use an initrd, not 
sure if it solves for kernel-ci.

> 
> Suggested-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
> Signed-off-by: Vignesh Raman <vignesh.raman@...labora.co
In any case:

Acked-by: Helen Koike <helen.koike@...labora.com>

> ---
> 
> v3:
>    - New patch in the series to enable CONFIG_REGULATOR_DA9211 in defconfig
> 
> ---
>   arch/arm64/configs/defconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index a25d783dfb95..ef22b532b63a 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -711,6 +711,7 @@ CONFIG_REGULATOR_AXP20X=y
>   CONFIG_REGULATOR_BD718XX=y
>   CONFIG_REGULATOR_BD9571MWV=y
>   CONFIG_REGULATOR_CROS_EC=y
> +CONFIG_REGULATOR_DA9211=m

Question for the maintainers: would it be acceptable to make it a =y 
instead of =m here ? Since this is something required for booting.

Regards,
Helen

>   CONFIG_REGULATOR_FAN53555=y
>   CONFIG_REGULATOR_GPIO=y
>   CONFIG_REGULATOR_HI6421V530=y