linux-kernel - Re: [PATCH v2] selftests/user_events: Fix failures when user

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230912171234.GA3704-beaub@linux.microsoft.com>
Date:   Tue, 12 Sep 2023 10:12:34 -0700
From:   Beau Belgrave <beaub@...ux.microsoft.com>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     Mark Brown <broonie@...nel.org>, shuah@...nel.org,
        mhiramat@...nel.org, linux-kernel@...r.kernel.org,
        linux-kselftest@...r.kernel.org, naresh.kamboju@...aro.org,
        anders.roxell@...aro.org, arnd@...db.de
Subject: Re: [PATCH v2] selftests/user_events: Fix failures when user_events
 is not installed

On Fri, Sep 08, 2023 at 09:27:12PM -0400, Steven Rostedt wrote:
> On Sat, 9 Sep 2023 00:33:05 +0100
> Mark Brown <broonie@...nel.org> wrote:
> 
> > On Fri, Sep 08, 2023 at 08:19:16PM +0000, Beau Belgrave wrote:
> > 
> > > Add common methods to detect if tracefs and user_events is enabled. If
> > > either is not enabled skip the test. If tracefs is enabled, but is not
> > > mounted, mount tracefs and fail if there were any errors. Fail if not
> > > run as root.  
> > 
> > This will leave tracefs mounted if it was not already mounted which is a
> > change to the system configuration.  While that may happen if things go
> > wrong during a test we should probably avoid actively doing this and
> > either only skip or try to umount at the end of the test if we mounted
> > ourselves.
> 
> LOL! Beau just asked me yesterday if anyone would care if the test mounted
> tracefs and left it mounted. I told him "no" as ftracetest in the selftests
> already do that.
> 
> I guess I was wrong and some people do care ;-)
> 
> -- Steve

It looks like this change got applied [1] to the fixes branch of
linux-kselftest. I can either send a V3 with this addressed or build a
patch based upon the fixes branch on top of this one to address it.

Which way do you all prefer?

Thanks,
-Beau

1. https://git.kernel.org/shuah/linux-kselftest/c/a06023a8f78d