linux-kernel - Re: [PATCH net-next v1 2/2] net: core: Sort headers alphabetically

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <32a8715a63b686aa0ac19fdae22b5d605d47ae35.camel@redhat.com>
Date:   Tue, 12 Sep 2023 19:25:48 +0200
From:   Paolo Abeni <pabeni@...hat.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Simon Horman <horms@...nel.org>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, bpf@...r.kernel.org,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>
Subject: Re: [PATCH net-next v1 2/2] net: core: Sort headers alphabetically

On Tue, 2023-09-12 at 20:04 +0300, Andy Shevchenko wrote:
> On Tue, Sep 12, 2023 at 06:53:23PM +0200, Paolo Abeni wrote:
> > On Tue, 2023-09-12 at 19:35 +0300, Andy Shevchenko wrote:
> > > On Tue, Sep 12, 2023 at 05:20:31PM +0200, Simon Horman wrote:
> > > > On Mon, Sep 11, 2023 at 06:45:34PM +0300, Andy Shevchenko wrote:
> > > > > It's rather a gigantic list of heards that is very hard to follow.
> > > > > Sorting helps to see what's already included and what's not.
> > > > > It improves a maintainability in a long term.
> > > > > 
> > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> > > > 
> > > > Hi Andy,
> > > > 
> > > > At the risk of bike shedding, the sort function of Vim, when operating
> > > > with the C locale, gives a slightly different order, as experssed by
> > > > this incremental diff.
> > > > 
> > > > I have no objections to your oder, but I'm slightly curious as
> > > > to how it came about.
> > > 
> > > !sort which is external command.
> > > 
> > > $ locale -k LC_COLLATE
> > > collate-nrules=4
> > > collate-rulesets=""
> > > collate-symb-hash-sizemb=1303
> > > collate-codeset="UTF-8"
> > 
> > I'm unsure this change is worthy. It will make any later fix touching
> > the header list more difficult to backport, and I don't see a great
> > direct advantage.
> 
> As Rasmus put it here
> https://lore.kernel.org/lkml/5eca0ab5-84be-2d8f-e0b3-c9fdfa961826@rasmusvillemoes.dk/
> In short term you can argue that it's not beneficial, but in long term it's given
> less conflicts.
> 
> > Please repost the first patch standalone.
> 
> Why to repost, what did I miss? It's available via lore, just run
> 
>   b4 am -slt -P _ 20230911154534.4174265-1-andriy.shevchenko@...ux.intel.com
> 
> to get it :-)

It's fairly better if actions (changes) on patches are taken by the
submitter: it scales way better, and if the other path take places we
can be easily flooded with small (but likely increasingly less smaller)
requests that will soon prevent any other activity from being taken.

Please, repost the single patch, it would be easier to me.

Thanks!

Paolo