linux-kernel - Re: [PATCH v2 1/3] crypto: mxs-dcp: Add support for hardware provided keys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <CVH4BKBIAG68.17652WFGQ44EQ@suppilovahvero>
Date:   Tue, 12 Sep 2023 20:34:27 +0300
From:   "Jarkko Sakkinen" <jarkko@...nel.org>
To:     "David Gstir" <david@...ma-star.at>,
        "Mimi Zohar" <zohar@...ux.ibm.com>,
        "James Bottomley" <jejb@...ux.ibm.com>,
        "Herbert Xu" <herbert@...dor.apana.org.au>,
        "David S. Miller" <davem@...emloft.net>
Cc:     "Shawn Guo" <shawnguo@...nel.org>,
        "Jonathan Corbet" <corbet@....net>,
        "Sascha Hauer" <s.hauer@...gutronix.de>,
        "Pengutronix Kernel Team" <kernel@...gutronix.de>,
        "Fabio Estevam" <festevam@...il.com>,
        "NXP Linux Team" <linux-imx@....com>,
        "Ahmad Fatoum" <a.fatoum@...gutronix.de>,
        "sigma star Kernel Team" <upstream+dcp@...ma-star.at>,
        "David Howells" <dhowells@...hat.com>,
        "Li Yang" <leoyang.li@....com>, "Paul Moore" <paul@...l-moore.com>,
        "James Morris" <jmorris@...ei.org>,
        "Serge E. Hallyn" <serge@...lyn.com>,
        "Paul E. McKenney" <paulmck@...nel.org>,
        "Randy Dunlap" <rdunlap@...radead.org>,
        "Catalin Marinas" <catalin.marinas@....com>,
        "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
        "Tejun Heo" <tj@...nel.org>,
        "Steven Rostedt (Google)" <rostedt@...dmis.org>,
        <linux-doc@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-integrity@...r.kernel.org>, <keyrings@...r.kernel.org>,
        <linux-crypto@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linuxppc-dev@...ts.ozlabs.org>,
        <linux-security-module@...r.kernel.org>,
        "Richard Weinberger" <richard@....at>,
        "David Oberhollenzer" <david.oberhollenzer@...ma-star.at>
Subject: Re: [PATCH v2 1/3] crypto: mxs-dcp: Add support for hardware
 provided keys

On Tue Sep 12, 2023 at 2:11 PM EEST, David Gstir wrote:
> @@ -101,6 +102,7 @@ struct dcp_async_ctx {
>  	struct crypto_skcipher		*fallback;
>  	unsigned int			key_len;
>  	uint8_t				key[AES_KEYSIZE_128];
> +	bool				refkey;
>  };

s/refkey/key_referenced/

No reason to obfuscate it, especially since there is no supporting
documentation.

BR, Jarkko