linux-kernel - Re: [PATCH 0/4] ASoC: cs35l56: Use PCI SSID to select specific firmware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 12 Sep 2023 13:39:56 -0400
From:   Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
To:     Richard Fitzgerald <rf@...nsource.cirrus.com>, broonie@...nel.org,
        yung-chuan.liao@...ux.intel.com, kai.vehmanen@...ux.intel.com,
        peter.ujfalusi@...ux.intel.com
Cc:     alsa-devel@...a-project.org, patches@...nsource.cirrus.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/4] ASoC: cs35l56: Use PCI SSID to select specific
 firmware



On 9/12/23 12:32, Richard Fitzgerald wrote:
> The PCI device registers contain a subsystem ID (SSID), that is
> separate from the silicon ID. The PCI specification defines it thus:
> 
> "They provide a mechanism for board vendors to distiguish their
>  boards from one another even thought the boards may have the same
>  PCI controller on them."
> 
> This allows the driver for the silicon part to apply board-speficic
> settings based on this SSID.
> 
> The CS35L56 driver uses this to select the correct firmware file for
> the board. The actual ID is part of the PCI register set of the
> host audio interface so this set of patches includes extracting the
> SSID from the Intel audio controller and passing it to the machine
> driver and then to ASoC components. Other PCI audio controllers
> will have the same SSID registers, so can use the same mechanism to
> pass the SSID.
> 
> Richard Fitzgerald (4):
>   ASoC: soc-card: Add storage for PCI SSID
>   ASoC: SOF: Pass PCI SSID to machine driver
>   ASoC: Intel: sof_sdw: Copy PCI SSID to struct snd_soc_card
>   ASoC: cs35l56: Use PCI SSID as the firmware UID

for the series

Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>


> 
>  include/sound/soc-acpi.h         |  7 ++++++
>  include/sound/soc-card.h         | 37 ++++++++++++++++++++++++++++++++
>  include/sound/soc.h              | 11 ++++++++++
>  include/sound/sof.h              |  8 +++++++
>  sound/soc/codecs/cs35l56.c       | 11 ++++++++++
>  sound/soc/intel/boards/sof_sdw.c |  6 ++++++
>  sound/soc/sof/sof-audio.c        |  7 ++++++
>  sound/soc/sof/sof-pci-dev.c      |  8 +++++++
>  8 files changed, 95 insertions(+)
>