linux-kernel - Re: [PATCH 1/2] dt-bindings: usb: add device for Genesys Logic hub gl3510

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1ja5ts4pyi.fsf@starbuckisacylon.baylibre.com>
Date:   Mon, 11 Sep 2023 18:46:24 +0200
From:   Jerome Brunet <jbrunet@...libre.com>
To:     Rob Herring <robh@...nel.org>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>, Da Xue <da@...re.computer>,
        linux-usb@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: usb: add device for Genesys Logic hub
 gl3510


On Thu 10 Aug 2023 at 17:17, Rob Herring <robh@...nel.org> wrote:

> On Tue, Aug 08, 2023 at 12:07:45PM +0200, Jerome Brunet wrote:
>> Add gl3510 USB 3 root hub device id
>> 
>> Signed-off-by: Jerome Brunet <jbrunet@...libre.com>
>> ---
>>  Documentation/devicetree/bindings/usb/genesys,gl850g.yaml | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>> 
>> diff --git a/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml b/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml
>> index cc4cf92b70d1..a7e7142651f8 100644
>> --- a/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml
>> +++ b/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml
>> @@ -4,7 +4,7 @@
>>  $id: http://devicetree.org/schemas/usb/genesys,gl850g.yaml#
>>  $schema: http://devicetree.org/meta-schemas/core.yaml#
>>  
>> -title: Genesys Logic GL850G USB 2.0 hub controller
>> +title: Genesys Logic USB hub controller
>>  
>>  maintainers:
>>    - Icenowy Zheng <uwu@...nowy.me>
>> @@ -17,6 +17,7 @@ properties:
>>      enum:
>>        - usb5e3,608
>>        - usb5e3,610
>> +      - usb5e3.626
>
> Should be a comma, not a period.
>

Good catch, thanks a lot

>>  
>>    reg: true
>>  
>> -- 
>> 2.40.1
>>