linux-kernel - Re: [PATCH] clk: tegra: fix error return case for recalc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1a1278715076b92ae73ac97950cd70e9.sboyd@kernel.org>
Date:   Tue, 12 Sep 2023 10:58:33 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Jonathan Hunter <jonathanh@...dia.com>,
        Mikko Perttunen <cyndis@...si.fi>,
        Thierry Reding <thierry.reding@...il.com>
Cc:     Timo Alho <talho@...dia.com>,
        Mikko Perttunen <mperttunen@...dia.com>,
        Peter De Schrijver <pdeschrijver@...dia.com>,
        Prashant Gaikwad <pgaikwad@...dia.com>,
        Michael Turquette <mturquette@...libre.com>,
        linux-clk@...r.kernel.org, linux-tegra@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clk: tegra: fix error return case for recalc_rate

Quoting Mikko Perttunen (2023-09-12 04:29:50)
> From: Timo Alho <talho@...dia.com>
> 
> tegra-bpmp clocks driver makes implicit conversion of signed error
> code to unsigned value in recalc_rate operation. The behavior for
> recalc_rate, according to it's specification, should be that "If the
> driver cannot figure out a rate for this clock, it must return 0."
> 
> Fixes: ca6f2796eef7 ("clk: tegra: Add BPMP clock driver")
> Signed-off-by: Timo Alho <talho@...dia.com>
> Signed-off-by: Mikko Perttunen <mperttunen@...dia.com>
> ---

Applied to clk-fixes