linux-kernel - Re: [PATCH 1/2] power: supply: bq24257_charger: Make chip type and name in sync

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230912214925.uukw4lxnopzswqz2@mercury.elektranox.org>
Date:   Tue, 12 Sep 2023 23:49:25 +0200
From:   Sebastian Reichel <sebastian.reichel@...labora.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Biju Das <biju.das.jz@...renesas.com>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Biju Das <biju.das.au@...il.com>
Subject: Re: [PATCH 1/2] power: supply: bq24257_charger: Make chip type and
 name in sync

Hi,

On Mon, Sep 11, 2023 at 01:15:09PM +0300, Andy Shevchenko wrote:
> On Sun, Sep 10, 2023 at 07:10:06AM +0000, Biju Das wrote:
> > Hi Andy Shevchenko,
> > > On Sat, Sep 02, 2023 at 08:33:30PM +0100, Biju Das wrote:
> 
> ...
> 
> > > > -	if (ACPI_HANDLE(dev)) {
> > > > -		acpi_id = acpi_match_device(dev->driver->acpi_match_table,
> > > > -					    &client->dev);
> > > > -		if (!acpi_id) {
> > > > -			dev_err(dev, "Failed to match ACPI device\n");
> > > > -			return -ENODEV;
> > > > -		}
> > > > -		bq->chip = (enum bq2425x_chip)acpi_id->driver_data;
> > > > -	} else {
> > > > -		bq->chip = (enum bq2425x_chip)id->driver_data;
> > > > -	}
> > > 
> > > Do we still need acpi.h after this change?
> > 
> > Yes, it is still needed as it is using 
> > ACPI_PTR.
> 
> Can we, please, drop ACPI_PTR() as it's more harmful than useful (same way as
> you dropped the ifdeffery for OF cases in other patches)?

I will go ahead and merge this series, ACPI_PTR() and
of_match_ptr() should be removed in a separate cleanup patch.

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)