linux-kernel - Re: [PATCH v3 1/2] soc/aspeed: Add host side BMC device driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c3981a8d-de56-448d-adb5-6685530b85f7@infradead.org>
Date:   Tue, 12 Sep 2023 15:15:49 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Ninad Palsule <ninad@...ux.ibm.com>, joel@....id.au,
        andrew@...id.au, eajames@...ux.ibm.com
Cc:     linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-aspeed@...ts.ozlabs.org
Subject: Re: [PATCH v3 1/2] soc/aspeed: Add host side BMC device driver

Hi,

diff --git a/drivers/soc/aspeed/Kconfig b/drivers/soc/aspeed/Kconfig
index f579ee0b5afa..8a4f096d84cd 100644
--- a/drivers/soc/aspeed/Kconfig
+++ b/drivers/soc/aspeed/Kconfig
@@ -52,6 +52,17 @@ config ASPEED_SOCINFO
 	help
 	  Say yes to support decoding of ASPEED BMC information.
 
+config ASPEED_HOST_BMC_DEV
+	bool "ASPEED SoC Host BMC device driver"
+	select SOC_BUS
+	default ARCH_ASPEED
+	depends on PCI
+	help
+	  Say yes to support PCIe based VUARTs from the host side. The end to
+          end VUART communication between host and BMC requires BMC side driver
+	  to activate VUART functionality. This is a driver for the BMC device
+          on host.

~~~
Please clean up that indentation. Consistently use one tab + 2 spaces,
as documented in coding-style.rst.

Also, can this be tristate instead of bool?  If not, why not?

Thanks.
-- 
~Randy