linux-kernel - Re: [PATCH net-next v4 2/2] net: dsa: microchip: Add drive strength configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230912223212.5allvc62okewwcym@skbuf>
Date:   Wed, 13 Sep 2023 01:32:12 +0300
From:   Vladimir Oltean <olteanv@...il.com>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     Oleksij Rempel <o.rempel@...gutronix.de>,
        "David S. Miller" <davem@...emloft.net>,
        Andrew Lunn <andrew@...n.ch>,
        Eric Dumazet <edumazet@...gle.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Woojung Huh <woojung.huh@...rochip.com>,
        Arun Ramadoss <arun.ramadoss@...rochip.com>,
        Conor Dooley <conor+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Rob Herring <robh+dt@...nel.org>, kernel@...gutronix.de,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        UNGLinuxDriver@...rochip.com,
        "Russell King (Oracle)" <linux@...linux.org.uk>,
        devicetree@...r.kernel.org
Subject: Re: [PATCH net-next v4 2/2] net: dsa: microchip: Add drive strength
 configuration

On Tue, Sep 12, 2023 at 08:38:05PM +0200, Christophe JAILLET wrote:
> Le 12/09/2023 à 13:35, Vladimir Oltean a écrit :
> > > +	if (!found)
> > > +		return 0;
> > 
> > Maybe "have_any_prop" would be a better name to avoid Christophe's confusion?
> 
> Not sure it worth it.
> 
> Christophe should learn to read code or avoid some quick feed-back before
> morning coffee :)
> 
> 'found' looks good enough.

Maybe I should have said "Christophe's (expressed) and my (unexpressed) confusion"?
Actually I had no time to be confused because I saw your comment first,
but I would have likely made the same suggestion regardless.