linux-kernel - Re: [PATCH 6.1 000/600] 6.1.53-rc1 review

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEUSe7_XA16yZAHA+YTbJygwaUYkU5gs=FnV9BAmQRYzwgVjvQ@mail.gmail.com>
Date:   Mon, 11 Sep 2023 20:25:03 -0600
From:   Daniel Díaz <daniel.diaz@...aro.org>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        stable@...r.kernel.org
Cc:     patches@...ts.linux.dev, linux-kernel@...r.kernel.org,
        torvalds@...ux-foundation.org, akpm@...ux-foundation.org,
        linux@...ck-us.net, shuah@...nel.org, patches@...nelci.org,
        lkft-triage@...ts.linaro.org, pavel@...x.de, jonathanh@...dia.com,
        f.fainelli@...il.com, sudipm.mukherjee@...il.com,
        srw@...dewatkins.net, rwarsow@....de, conor@...nel.org,
        jack@...e.cz
Subject: Re: [PATCH 6.1 000/600] 6.1.53-rc1 review

Hello!

On Mon, 11 Sept 2023 at 14:58, Daniel Díaz <daniel.diaz@...aro.org> wrote:
> On 11/09/23 7:40 a. m., Greg Kroah-Hartman wrote:
> > This is the start of the stable review cycle for the 6.1.53 release.
> > There are 600 patches in this series, all will be posted as a response
> > to this one.  If anyone has any issues with these being applied, please
> > let me know.
> >
> > Responses should be made by Wed, 13 Sep 2023 13:44:56 +0000.
> > Anything received after that time might be too late.
> >
> > The whole patch series can be found in one patch at:
> >       https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.1.53-rc1.gz
> > or in the git tree and branch at:
> >       git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.1.y
> > and the diffstat can be found below.
> >
> > thanks,
> >
> > greg k-h
>
> We're seeing this new warning:
> -----8<-----
>    /builds/linux/fs/udf/inode.c:892:6: warning: variable 'newblock' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
>      892 |         if (*err < 0)
>          |             ^~~~~~~~
>    /builds/linux/fs/udf/inode.c:914:9: note: uninitialized use occurs here
>      914 |         return newblock;
>          |                ^~~~~~~~
>    /builds/linux/fs/udf/inode.c:892:2: note: remove the 'if' if its condition is always false
>      892 |         if (*err < 0)
>          |         ^~~~~~~~~~~~~
>      893 |                 goto out_free;
>          |                 ~~~~~~~~~~~~~
>    /builds/linux/fs/udf/inode.c:699:34: note: initialize the variable 'newblock' to silence this warning
>      699 |         udf_pblk_t newblocknum, newblock;
>          |                                         ^
>          |                                          = 0
>    1 warning generated.
> ----->8-----
>
> That's with Clang 17 (and nightly) on:
> * arm
> * powerpc
> * s390

For what it's worth, bisection points to 903b487b5ba6 ("udf: Handle
error when adding extent to a file").

In order to reproduce:

  #pip3 install -U tuxmake
  tuxmake --runtime podman \
    --target-arch arm \
    --toolchain clang-17 \
    --kconfig multi_v5_defconfig \
    LLVM=1 LLVM_IAS=1

or:

  #pip3 install -U tuxmake
  tuxmake --runtime podman \
    --target-arch powerpc \
    --toolchain clang-17 \
    --kconfig defconfig \
    LLVM=1 LLVM_IAS=0 LD=powerpc64le-linux-gnu-ld

or:

  #pip3 install -U tuxmake
  tuxmake --runtime podman \
    --target-arch s390 \
    --toolchain clang-17 \
    --kconfig defconfig \
    LLVM_IAS=1


Greetings!

Daniel Díaz
daniel.diaz@...aro.org