linux-kernel - Re: [FIX PATCH] selftests: tracing: Fix to unmount tracefs for recovering environment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230911205718.5bc23f8d@gandalf.local.home>
Date:   Mon, 11 Sep 2023 20:57:18 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     "Masami Hiramatsu (Google)" <mhiramat@...nel.org>
Cc:     Shuah Khan <shuah@...nel.org>, Mark Brown <broonie@...nel.org>,
        linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org
Subject: Re: [FIX PATCH] selftests: tracing: Fix to unmount tracefs for
 recovering environment

On Tue, 12 Sep 2023 09:54:57 +0900
Masami Hiramatsu (Google) <mhiramat@...nel.org> wrote:

> > Shouldn't the above be:
> > 
> >      if [ ! -z "${UNMOUNT_DIR}" ]; then
> > 
> > ?  
> 
> I think both are good.
> What about using '-n' explictly?
> 
> [ -n "${UNMOUNT_DIR}" ]

Even better. Heh, I never even knew about that switch :-p

-- Steve