linux-kernel - Re: [RESEND][PATCH] tracing/synthetic: Fix order of struct trace_dynamic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230911180259.599a7909@gandalf.local.home>
Date:   Mon, 11 Sep 2023 18:02:59 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     "Masami Hiramatsu (Google)" <mhiramat@...nel.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Linux Trace Kernel <linux-trace-kernel@...r.kernel.org>,
        Mark Rutland <mark.rutland@....com>,
        Sven Schnelle <svens@...ux.ibm.com>
Subject: Re: [RESEND][PATCH] tracing/synthetic: Fix order of struct
 trace_dynamic_info

On Mon, 11 Sep 2023 09:26:12 +0900
Masami Hiramatsu (Google) <mhiramat@...nel.org> wrote:

> > Fix this and just to be safe also add "__packed".
> > 
> > Link: https://lore.kernel.org/all/20230908154417.5172e343@gandalf.local.home/  
> 
> Good catch! I'm not sure why this worked. Maybe we don't have any testcase
> for this feature?

We have a test case, it was broken by a change in the README :-p

I noticed issues with it, and then looked at the tests, fixed the test and
it failed. Before that, it was just reporting "unsupported", which is why I
included that fix with this queue.

  https://lore.kernel.org/linux-trace-kernel/20230614091046.2178539-1-naveen@kernel.org/

> 
> Acked-by: Masami Hiramatsu (Google) <mhiramat@...nel.org>

Thanks!

-- Steve