linux-kernel - Re: [PATCH v1 3/5] perf expr: Make YYDEBUG dependent on doing a debug build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM9d7cgCufCz9ti+j562rf1oNDo3BD7Tdc2bsYijDxBmZBrqFQ@mail.gmail.com>
Date:   Mon, 11 Sep 2023 23:00:05 -0700
From:   Namhyung Kim <namhyung@...nel.org>
To:     Ian Rogers <irogers@...gle.com>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...nel.org>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Kan Liang <kan.liang@...ux.intel.com>,
        James Clark <james.clark@....com>,
        Gaosheng Cui <cuigaosheng1@...wei.com>,
        Rob Herring <robh@...nel.org>,
        linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org,
        bpf@...r.kernel.org
Subject: Re: [PATCH v1 3/5] perf expr: Make YYDEBUG dependent on doing a debug build

On Mon, Sep 11, 2023 at 10:06 AM Ian Rogers <irogers@...gle.com> wrote:
>
> YYDEBUG enables line numbers and other error helpers in the generated
> expr-bison.c. These shouldn't be generated when debugging
> isn't enabled.
>
> Signed-off-by: Ian Rogers <irogers@...gle.com>

Acked-by: Namhyung Kim <namhyung@...nel.org>

Thanks,
Namhyung


> ---
>  tools/perf/util/expr.y | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/tools/perf/util/expr.y b/tools/perf/util/expr.y
> index 6c93b358cc2d..e364790babb5 100644
> --- a/tools/perf/util/expr.y
> +++ b/tools/perf/util/expr.y
> @@ -1,6 +1,8 @@
>  /* Simple expression parser */
>  %{
> +#ifndef NDEBUG
>  #define YYDEBUG 1
> +#endif
>  #include <assert.h>
>  #include <math.h>
>  #include <stdlib.h>
> --
> 2.42.0.283.g2d96d420d3-goog
>