linux-kernel - Re: [PATCH v8 01/11] btrfs: add raid stripe tree definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6d3b0ffa-2c12-495d-8b77-2eb8afc83e93@wdc.com>
Date:   Tue, 12 Sep 2023 06:09:52 +0000
From:   Johannes Thumshirn <Johannes.Thumshirn@....com>
To:     Damien Le Moal <dlemoal@...nel.org>, Chris Mason <clm@...com>,
        Josef Bacik <josef@...icpanda.com>,
        David Sterba <dsterba@...e.com>
CC:     Christoph Hellwig <hch@....de>,
        Naohiro Aota <Naohiro.Aota@....com>, Qu Wenruo <wqu@...e.com>,
        "linux-btrfs@...r.kernel.org" <linux-btrfs@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v8 01/11] btrfs: add raid stripe tree definitions

On 11.09.23 23:01, Damien Le Moal wrote:
>> diff --git a/include/uapi/linux/btrfs_tree.h b/include/uapi/linux/btrfs_tree.h
>> index fc3c32186d7e..3fb758ce3ac0 100644
>> --- a/include/uapi/linux/btrfs_tree.h
>> +++ b/include/uapi/linux/btrfs_tree.h
>> @@ -4,9 +4,8 @@
>>   
>>   #include <linux/btrfs.h>
>>   #include <linux/types.h>
>> -#ifdef __KERNEL__
>>   #include <linux/stddef.h>
>> -#else
>> +#ifndef __KERNEL__
>>   #include <stddef.h>
>>   #endif
> 
> This change seems unrelated to the RAID stripe tree. Should this be a patch on
> its own ?

Nope it isn't. This patch introduces a user of __DECLARE_FLEX_ARRAY() 
and without the moved ifdef userspace can't find the definition of it.