lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2059cb67-241b-e236-9a97-195a327828d6@oss.nxp.com>
Date:   Tue, 12 Sep 2023 14:32:24 +0800
From:   Peng Fan <peng.fan@....nxp.com>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        abelvesa@...nel.org, peng.fan@....com, mturquette@...libre.com,
        sboyd@...nel.org, shawnguo@...nel.org, s.hauer@...gutronix.de,
        kernel@...gutronix.de, festevam@...il.com, linux-imx@....com,
        shengjiu.wang@....com
Cc:     linux-clk@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 0/5] clk: imx: imx8: Fix some error handling paths



On 8/27/2023 5:37 PM, Christophe JAILLET wrote:
> This serie fix some error handling paths. It is split in different patches to
> ease review because the issues are unrelated and the proposed fixes are maybe
> wrong (I don't have the hardware to test anything)
> 
> Patch 2 and 3 are more speculative than the 3 oher ones. Review with care.
> 
> 
> Finally, I got some problem when generating the serie, and some patches have
> been hand-modified afterwards.
> They look good to me, but I hope have not screwed up things...
> 
> Christophe JAILLET (5):
>    clk: imx: imx8: Fix an error handling path in
>      clk_imx_acm_attach_pm_domains()
>    clk: imx: imx8: Fix an error handling path if
>      devm_clk_hw_register_mux_parent_data_table() fails
>    clk: imx: imx8: Fix an error handling path in imx8_acm_clk_probe()
>    clk: imx: imx8: Add a message in case of
>      devm_clk_hw_register_mux_parent_data_table() error
>    clk: imx: imx8: Simplify clk_imx_acm_detach_pm_domains()
> 
>   drivers/clk/imx/clk-imx8-acm.c | 27 +++++++++++++++------------
>   1 file changed, 15 insertions(+), 12 deletions(-)
> 

LGTM, for the patchset

Reviewed-by: Peng Fan <peng.fan@....com>

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ