linux-kernel - Re: [PATCH v3 1/3] dt-bindings: reset: Add compatible and DT bindings for Amlogic C3 Reset Controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 12 Sep 2023 14:37:59 +0800
From:   Zelong Dong <Zelong.Dong@...ogic.com>
To:     neil.armstrong@...aro.org, Philipp Zabel <p.zabel@...gutronix.de>,
        Kevin Hilman <khilman@...libre.com>,
        Rob Herring <robh+dt@...nel.org>,
        Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
        Jerome Brunet <jbrunet@...libre.com>
Cc:     linux-kernel@...r.kernel.org, linux-amlogic@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        devicetree@...r.kernel.org, kelvin.zhang@...ogic.com
Subject: Re: [PATCH v3 1/3] dt-bindings: reset: Add compatible and DT bindings
 for Amlogic C3 Reset Controller

在 2023/7/31 17:17, Neil Armstrong 写道:
> On 28/07/2023 17:49, Philipp Zabel wrote:
>> On Mi, 2023-07-19 at 14:09 +0800, zelong dong wrote:
>>> From: Zelong Dong <zelong.dong@...ogic.com>
>>>
>>> Add new compatible and DT bindings for Amlogic C3 Reset Controller
>>>
>>> Signed-off-by: Zelong Dong <zelong.dong@...ogic.com>
>>> ---
>>>   .../bindings/reset/amlogic,meson-reset.yaml   |   1 +
>>>   include/dt-bindings/reset/amlogic,c3-reset.h  | 119 ++++++++++++++++++
>>>   2 files changed, 120 insertions(+)
>>>   create mode 100644 include/dt-bindings/reset/amlogic,c3-reset.h
>>>
>>> diff --git 
>>> a/Documentation/devicetree/bindings/reset/amlogic,meson-reset.yaml 
>>> b/Documentation/devicetree/bindings/reset/amlogic,meson-reset.yaml
>>> index d3fdee89d4f8..f0c6c0df0ce3 100644
>>> --- a/Documentation/devicetree/bindings/reset/amlogic,meson-reset.yaml
>>> +++ b/Documentation/devicetree/bindings/reset/amlogic,meson-reset.yaml
>>> @@ -18,6 +18,7 @@ properties:
>>>         - amlogic,meson-axg-reset # Reset Controller on AXG and 
>>> compatible SoCs
>>>         - amlogic,meson-a1-reset # Reset Controller on A1 and 
>>> compatible SoCs
>>>         - amlogic,meson-s4-reset # Reset Controller on S4 and 
>>> compatible SoCs
>>> +      - amlogic,c3-reset # Reset Controller on C3 and compatible SoCs
>>>
>>>     reg:
>>>       maxItems: 1
>>> diff --git a/include/dt-bindings/reset/amlogic,c3-reset.h 
>>> b/include/dt-bindings/reset/amlogic,c3-reset.h
>>> new file mode 100644
>>> index 000000000000..d9127863f603
>>> --- /dev/null
>>> +++ b/include/dt-bindings/reset/amlogic,c3-reset.h
>>
>> Given that this is only included by
>> arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi, should this header be
>> moved to arch/arm64/boot/dts/amlogic ?
> 
> Maybe I missed something, but since when should we move bindings headers 
> to arch/xxx/boot/dts/vendor ?
> 
> Neil
> 
>>
>> regards
>> Philipp
> 
Hi,
It's been a while, how will we deal with this patch ?
Should we let this patch apply first? If Amlogic reset bindings headers 
need to be moved to arch/xxx/boot/dts/vendor, could we apply it in a 
separate change?