linux-kernel - Re: [PATCH v2] dt-bindings: arm64: dts: mediatek: add description for mt8365-evk board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <89341643-3d0e-89f6-f81c-579c56a358a3@linaro.org>
Date:   Tue, 12 Sep 2023 08:52:34 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Macpaul Lin <macpaul.lin@...iatek.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>,
        Bernhard Rosenkränzer <bero@...libre.com>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org
Cc:     Bear Wang <bear.wang@...iatek.com>,
        Pablo Sun <pablo.sun@...iatek.com>,
        Macpaul Lin <macpaul@...il.com>
Subject: Re: [PATCH v2] dt-bindings: arm64: dts: mediatek: add description for
 mt8365-evk board

On 12/09/2023 08:29, Macpaul Lin wrote:
> 
>>> Signed-off-by: Macpaul Lin <macpaul.lin@...iatek.com>
>>> ---
>>>  Documentation/devicetree/bindings/arm/mediatek.yaml | 3 ++-
>>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> change for v2:
>>>  - rebase this patch to follow the v5 patch set of mt8395.
>>>   - depends on https://lore.kernel.org/lkml/20230909132819.21626-2-macpaul.lin@mediatek.com/T/
>>>  - Fix description as a single board.
>>>
>>> diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml
>>> index 2e8ad49c3479..b163995e32d5 100644
>>> --- a/Documentation/devicetree/bindings/arm/mediatek.yaml
>>> +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml
>>> @@ -244,7 +244,8 @@ properties:
>>>            - enum:
>>>                - mediatek,mt8183-pumpkin
>>>            - const: mediatek,mt8183
>>> -      - items:
>>> +      - description: MediaTek Genio 350 Board (Genio 350 EVK)
>>
>> Drop, no need, redundant (copies the compatible) and your other entries
>> do not have it.
> 
> The primary objective of this patch is to incorporate a description that 
> will prevent users from confusing this platform with others.

How platform can be confused? The compatibles define it, not description.

> Additionally, it aids in identifying this as a "Genio EVK" for marketing 
> purposes.

Kernel is not a place for marketing.

> Thanks
> Macpaul Lin

Best regards,
Krzysztof