[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <0fce832b81d676da8bde28bc7acf4d56932f244d.camel@kylinos.cn>
Date: Tue, 12 Sep 2023 15:06:35 +0800
From: zongmin zhou <zhouzongmin@...inos.cn>
To: airlied@...hat.com, kraxel@...hat.com, airlied@...il.com,
daniel@...ll.ch
Cc: virtualization@...ts.linux-foundation.org,
spice-devel@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
linux-kernel@...r.kernel.org
Subject: Re: [RESEND PATCH] drm/qxl: prevent memory leak
On Tue, 2023-08-01 at 10:53 +0800, Zongmin Zhou wrote:
> The allocated memory for qdev->dumb_heads should be released
> in qxl_destroy_monitors_object before qxl suspend.
> otherwise,qxl_create_monitors_object will be called to
> reallocate memory for qdev->dumb_heads after qxl resume,
> it will cause memory leak.
>
> Signed-off-by: Zongmin Zhou<zhouzongmin@...inos.cn>
> ---
> drivers/gpu/drm/qxl/qxl_display.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/qxl/qxl_display.c
> b/drivers/gpu/drm/qxl/qxl_display.c
> index 6492a70e3c39..404b0483bb7c 100644
> --- a/drivers/gpu/drm/qxl/qxl_display.c
> +++ b/drivers/gpu/drm/qxl/qxl_display.c
> @@ -1229,6 +1229,9 @@ int qxl_destroy_monitors_object(struct
> qxl_device *qdev)
> if (!qdev->monitors_config_bo)
> return 0;
>
> + kfree(qdev->dumb_heads);
> + qdev->dumb_heads = NULL;
> +
> qdev->monitors_config = NULL;
> qdev->ram_header->monitors_config = 0;
>
Friendly ping...
Hello, I sent this patch a few months ago.
Could you please help me review it as well and see if there are any
issues?
I'm looking forward to your reply.
Thanks
Powered by blists - more mailing lists