| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <9fe6f075-c5c0-3f59-d6ea-dc6766d74c96@collabora.com>
Date: Tue, 12 Sep 2023 10:07:48 +0200
From: AngeloGioacchino Del Regno
<angelogioacchino.delregno@...labora.com>
To: Yunfei Dong <yunfei.dong@...iatek.com>,
Nícolas F . R . A . Prado
<nfraprado@...labora.com>,
Nicolas Dufresne <nicolas.dufresne@...labora.com>,
Hans Verkuil <hverkuil-cisco@...all.nl>,
Benjamin Gaignard <benjamin.gaignard@...labora.com>,
Nathan Hebert <nhebert@...omium.org>
Cc: Chen-Yu Tsai <wenst@...omium.org>,
Hsin-Yi Wang <hsinyi@...omium.org>,
Fritz Koenig <frkoenig@...omium.org>,
Daniel Vetter <daniel@...ll.ch>,
Steve Cho <stevecho@...omium.org>, linux-media@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org,
linux-mediatek@...ts.infradead.org,
Project_Global_Chrome_Upstream_Group@...iatek.com
Subject: Re: [PATCH 03/14] media: mediatek: vcodec: send share memory data to
optee
Il 11/09/23 14:59, Yunfei Dong ha scritto:
> Setting msg and vsi information to shared buffer, then call tee invoke
> function to send it to optee-os.
>
> Signed-off-by: Yunfei Dong <yunfei.dong@...iatek.com>
> ---
> .../vcodec/decoder/mtk_vcodec_dec_optee.c | 139 ++++++++++++++++++
> .../vcodec/decoder/mtk_vcodec_dec_optee.h | 51 +++++++
> 2 files changed, 190 insertions(+)
>
> diff --git a/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_optee.c b/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_optee.c
> index 806ca87c8de7..d16496003a39 100644
> --- a/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_optee.c
> +++ b/drivers/media/platform/mediatek/vcodec/decoder/mtk_vcodec_dec_optee.c
> @@ -232,3 +232,142 @@ void mtk_vcodec_dec_optee_release(struct mtk_vdec_optee_private *optee_private)
> mutex_unlock(&optee_private->tee_mutex);
> }
> EXPORT_SYMBOL_GPL(mtk_vcodec_dec_optee_release);
> +
> +static int mtk_vcodec_dec_optee_fill_shm(struct tee_param *command_params,
> + struct mtk_vdec_optee_shm_memref *shm_memref,
> + struct mtk_vdec_optee_data_to_shm *data,
> + int index)
> +{
> + if (!data->msg_buf_size[index] || !data->msg_buf[index]) {
> + pr_err(MTK_DBG_VCODEC_STR "tee invalid buf param: %d.\n", index);
> + return -EINVAL;
> + }
> +
> + *command_params = (struct tee_param) {
> + .attr = shm_memref->param_type,
> + .u.memref = {
> + .shm = shm_memref->msg_shm,
> + .size = data->msg_buf_size[index],
> + .shm_offs = 0,
> + },
> + };
> +
> + if (!shm_memref->copy_to_ta) {
> + pr_debug(MTK_DBG_VCODEC_STR "share memref data: 0x%x param_type:%llu.\n",
> + *((unsigned int *)shm_memref->msg_shm_ca_buf), shm_memref->param_type);
> + return 0;
> + }
> +
> + memset(shm_memref->msg_shm_ca_buf, 0, shm_memref->msg_shm_size);
> + memcpy(shm_memref->msg_shm_ca_buf, data->msg_buf[index], data->msg_buf_size[index]);
> +
> + pr_debug(MTK_DBG_VCODEC_STR "share memref data => msg id:0x%x 0x%x param_type:%llu.\n",
> + *((unsigned int *)data->msg_buf[index]),
> + *((unsigned int *)shm_memref->msg_shm_ca_buf),
> + shm_memref->param_type);
dev_dbg()?
> +
> + return 0;
> +}
> +
> +void mtk_vcodec_dec_optee_set_data(struct mtk_vdec_optee_data_to_shm *data,
> + void *buf, int buf_size,
> + enum mtk_vdec_optee_data_index index)
> +{
> + data->msg_buf[index] = buf;
> + data->msg_buf_size[index] = buf_size;
> +}
> +EXPORT_SYMBOL_GPL(mtk_vcodec_dec_optee_set_data);
> +
> +int mtk_vcodec_dec_optee_invokd_cmd(struct mtk_vdec_optee_private *optee_private,
> + enum mtk_vdec_hw_id hw_id,
> + struct mtk_vdec_optee_data_to_shm *data)
> +{
> + struct tee_ioctl_invoke_arg trans_args;
> + struct tee_param command_params[MTK_OPTEE_MAX_TEE_PARAMS];
> + struct mtk_vdec_optee_ca_info *ca_info;
> + struct mtk_vdec_optee_shm_memref *shm_memref;
> + int ret = 0, index;
int i, ret;
> +
> + if (hw_id == MTK_VDEC_LAT0)
> + ca_info = &optee_private->lat_ca;
> + else
> + ca_info = &optee_private->core_ca;
> +
> + memset(&trans_args, 0, sizeof(trans_args));
> + memset(command_params, 0, sizeof(command_params));
> +
> + trans_args = (struct tee_ioctl_invoke_arg) {
> + .func = ca_info->vdec_session_func,
> + .session = ca_info->vdec_session_id,
> + .num_params = MTK_OPTEE_MAX_TEE_PARAMS,
> + };
> +
> + /* Fill msg command parameters */
> + for (index = 0; index < MTK_OPTEE_MAX_TEE_PARAMS; index++) {
> + shm_memref = &ca_info->shm_memref[index];
> +
> + if (shm_memref->param_type == TEE_IOCTL_PARAM_ATTR_TYPE_NONE ||
> + data->msg_buf_size[index] == 0)
> + continue;
> +
> + pr_debug(MTK_DBG_VCODEC_STR "tee share memory data size: %d -> %d.\n",
> + data->msg_buf_size[index], shm_memref->msg_shm_size);
> +
dev_dbg()
> + if (data->msg_buf_size[index] > shm_memref->msg_shm_size) {
> + pr_err(MTK_DBG_VCODEC_STR "tee buf size big then shm size(%d -> %d).\n",
> + data->msg_buf_size[index], shm_memref->msg_shm_size);
dev_err()
> + return -EINVAL;
> + }
> +
> + ret = mtk_vcodec_dec_optee_fill_shm(&command_params[index], shm_memref,
> + data, index);
> + if (ret)
> + return ret;
> + }
> +
> + ret = tee_client_invoke_func(optee_private->tee_vdec_ctx, &trans_args, command_params);
> + if (ret < 0 || trans_args.ret != 0) {
> + pr_err(MTK_DBG_VCODEC_STR "tee submit command fail: 0x%x 0x%x.\n",
> + trans_args.ret, ret);
dev_err()
> + return (ret < 0) ? ret : trans_args.ret;
> + }
> +
> + /* clear all attrs, set all command param to unused */
> + for (index = 0; index < MTK_OPTEE_MAX_TEE_PARAMS; index++) {
> + data->msg_buf[index] = NULL;
> + data->msg_buf_size[index] = 0;
> + }
> +
> + return 0;
> +}
> +EXPORT_SYMBOL_GPL(mtk_vcodec_dec_optee_invokd_cmd);
> +
Regards,
Angelo
Powered by blists - more mailing lists