linux-kernel - Re: [PATCH 2/2] pinctrl: pinmux: Use dev_err_probe() in pin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdbTZYnehWiWFgY3KJLFdS47RpxOp-Cct4BDqgYCYtd2vw@mail.gmail.com>
Date:   Tue, 12 Sep 2023 10:15:31 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Jernej Skrabec <jernej.skrabec@...il.com>
Cc:     linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] pinctrl: pinmux: Use dev_err_probe() in pin_request()

Hi Jenej,

thanks for your patch!

On Sat, Sep 9, 2023 at 8:36 AM Jernej Skrabec <jernej.skrabec@...il.com> wrote:

> Use dev_err_probe() when printing error message in pin_request() since
> it may fail with -EPROBE_DEFER.
>
> Signed-off-by: Jernej Skrabec <jernej.skrabec@...il.com>
(...)

>         if (status)
> -               dev_err(pctldev->dev, "pin-%d (%s) status %d\n",
> -                       pin, owner, status);
> +               dev_err_probe(pctldev->dev, "pin-%d (%s) status %d\n",
> +                             pin, owner, status);
>
>         return status;

That's not how you use dev_err_probe()

Just replace all of the lines above with return dev_err_probe(...)

Yours,
Linus Walleij