linux-kernel - Re: [PATCH net-next] qmi_wwan: Add rawip module param

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <874jjzafnj.fsf@miraculix.mork.no>
Date:   Tue, 12 Sep 2023 11:45:36 +0200
From:   Bjørn Mork <bjorn@...k.no>
To:     Stefan x Nilsson <stefan.x.nilsson@...s.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, <netdev@...r.kernel.org>,
        <linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <kernel@...s.com>
Subject: Re: [PATCH net-next] qmi_wwan: Add rawip module param

Stefan x Nilsson <stefan.x.nilsson@...s.com> writes:

> Would a quirk on the affected modem be an better/acceptable solution?

More acceptable but still needs justification.

I'm probably missing something, but I don't see the described issue even
if I assume a device crashing if it sees an ethernet header.

The netdev and associated chardev are created when a USB device is
connected.  The device knows nothing about this.  It answers a few USB
descriptor requests and that's it.  The host is free to switch the
netdev to raw-ip framing before bringing it up.  There is no need to
send any frames with eithernet header.  There is no relationship between
framing and the QMI control channel.  But the host is in complete
control of any communication there too, so it wouldn't be a problam if
there were.

Bjørn