linux-kernel - Re: [PATCH v2 04/13] comedi: comedi_8254: Conditionally remove I/O port support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 13 Sep 2023 17:46:53 +0100
From:   Ian Abbott <abbotti@....co.uk>
To:     linux-kernel@...r.kernel.org
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        H Hartley Sweeten <hsweeten@...ionengravers.com>,
        Arnd Bergmann <arnd@...nel.org>,
        Niklas Schnelle <schnelle@...ux.ibm.com>
Subject: Re: [PATCH v2 04/13] comedi: comedi_8254: Conditionally remove I/O
 port support

On 13/09/2023 17:40, Ian Abbott wrote:
> The comedi_8254 module supports both port I/O and memory-mapped I/O.
> In a future patch, the port I/O functions (`inb()`, `outb()`, and
> friends) will only be declared if the `HAS_IOPORT` configuration option
> is enabled.
> 
> Conditionally compile the parts of the module that use port I/O so they
> are compiled if and only if the `CONFIG_HAS_IOPORT` macro is defined, so
> that it can still be built if the port I/O functions have not been
> declared.  If `CONFIG_HAS_IOPORT` is undefined, replace the GPL-exported
> `comedi_8254_io_alloc()` function with a dummy static inline version
> that just returns `ERR_PTR(-ENXIO)`.
> 
> Cc: Arnd Bergmann <arnd@...nel.org>
> Cc: Niklas Schnelle <schnelle@...ux.ibm.com>
> Signed-off-by: Ian Abbott <abbotti@....co.uk>
> v2: N/A
> ---

Oops. I forgot the --- dividing line before the patch change log.  (Same 
mistake in patches 06 and 09.  Time for a v3.  Sorry about that.

-- 
-=( Ian Abbott <abbotti@....co.uk> || MEV Ltd. is a company  )=-
-=( registered in England & Wales.  Regd. number: 02862268.  )=-
-=( Regd. addr.: S11 & 12 Building 67, Europa Business Park, )=-
-=( Bird Hall Lane, STOCKPORT, SK3 0XA, UK. || www.mev.co.uk )=-