linux-kernel - Re: [PATCH] pinctrl: nuvoton: Fix up Kconfig deps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <140e7f79-4e03-47ec-99de-90871ca8d445@infradead.org>
Date:   Wed, 13 Sep 2023 10:12:44 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Linus Walleij <linus.walleij@...aro.org>,
        Tomer Maimon <tmaimon77@...il.com>
Cc:     linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pinctrl: nuvoton: Fix up Kconfig deps



On 9/13/23 01:50, Linus Walleij wrote:
> We have build errors due to missing dependency on OF.
> Add the dependency and do it the same way for all three
> Nuvotons while we are at it.
> 
> Reported-by: Randy Dunlap <rdunlap@...radead.org>
> Signed-off-by: Linus Walleij <linus.walleij@...aro.org>

Works for me. Thanks.

Acked-by: Randy Dunlap <rdunlap@...radead.org>
Tested-by: Randy Dunlap <rdunlap@...radead.org>

> ---
>  drivers/pinctrl/nuvoton/Kconfig | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/pinctrl/nuvoton/Kconfig b/drivers/pinctrl/nuvoton/Kconfig
> index 612e7ba02238..2abbfcec1fae 100644
> --- a/drivers/pinctrl/nuvoton/Kconfig
> +++ b/drivers/pinctrl/nuvoton/Kconfig
> @@ -2,8 +2,7 @@
>  
>  config PINCTRL_WPCM450
>  	tristate "Pinctrl and GPIO driver for Nuvoton WPCM450"
> -	depends on ARCH_WPCM450 || COMPILE_TEST
> -	depends on OF
> +	depends on (ARCH_WPCM450 || COMPILE_TEST) && OF
>  	select PINMUX
>  	select PINCONF
>  	select GENERIC_PINCONF
> @@ -35,7 +34,7 @@ config PINCTRL_NPCM7XX
>  
>  config PINCTRL_NPCM8XX
>  	tristate "Pinctrl and GPIO driver for Nuvoton NPCM8XX"
> -	depends on ARCH_NPCM || COMPILE_TEST
> +	depends on (ARCH_NPCM || COMPILE_TEST) && OF
>  	select PINMUX
>  	select PINCONF
>  	select GENERIC_PINCONF
> 
> ---
> base-commit: c9336ebe87e77f92ed04a86c0131a0310d0e200d
> change-id: 20230913-novoton-kconfig-895c60755500
> 
> Best regards,

-- 
~Randy