linux-kernel - Re: [RFC PATCH 01/10] drm/panel: Don't store+check prepared/enabled for simple cases

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 13 Sep 2023 11:20:19 -0700
From:   Doug Anderson <dianders@...omium.org>
To:     dri-devel@...ts.freedesktop.org, Maxime Ripard <mripard@...nel.org>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Daniel Vetter <daniel@...ll.ch>,
        David Airlie <airlied@...il.com>,
        Jianhua Lu <lujianhua000@...il.com>,
        Neil Armstrong <neil.armstrong@...aro.org>,
        Sam Ravnborg <sam@...nborg.org>, linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH 01/10] drm/panel: Don't store+check prepared/enabled
 for simple cases

Hi,

On Fri, Aug 4, 2023 at 2:07 PM Douglas Anderson <dianders@...omium.org> wrote:
>
> As talked about in commit d2aacaf07395 ("drm/panel: Check for already
> prepared/enabled in drm_panel"), we want to remove needless code from
> panel drivers that was storing and double-checking the
> prepared/enabled state. Even if someone was relying on the
> double-check before, that double-check is now in the core and not
> needed in individual drivers.
>
> This pile of panel drivers appears to be simple to handle. Based on
> code inspection they seemed to be using the prepared/enabled state
> simply for double-checking that nothing else in the kernel called them
> inconsistently. Now that the core drm_panel is doing the double
> checking (and warning) it should be very clear that these devices
> don't need their own double-check.
>
> Signed-off-by: Douglas Anderson <dianders@...omium.org>
> ---
>
>  .../drm/panel/panel-asus-z00t-tm5p5-n35596.c  |  9 -----
>  .../gpu/drm/panel/panel-boe-bf060y8m-aj0.c    |  9 -----
>  drivers/gpu/drm/panel/panel-jdi-fhd-r63452.c  |  9 -----
>  drivers/gpu/drm/panel/panel-novatek-nt35950.c |  9 -----
>  drivers/gpu/drm/panel/panel-novatek-nt36523.c | 12 ------
>  drivers/gpu/drm/panel/panel-raydium-rm68200.c | 38 -------------------
>  .../panel/panel-samsung-s6e88a0-ams452ef01.c  | 10 -----
>  drivers/gpu/drm/panel/panel-samsung-sofef00.c |  9 -----
>  .../gpu/drm/panel/panel-sharp-ls060t1sx01.c   | 10 -----
>  drivers/gpu/drm/panel/panel-sony-td4353-jdi.c |  9 -----
>  .../panel/panel-sony-tulip-truly-nt35521.c    | 18 ---------
>  .../drm/panel/panel-startek-kd070fhfid015.c   | 11 ------
>  drivers/gpu/drm/panel/panel-truly-nt35597.c   | 20 ----------
>  drivers/gpu/drm/panel/panel-visionox-r66451.c | 16 --------
>  .../gpu/drm/panel/panel-visionox-rm69299.c    |  8 ----
>  .../gpu/drm/panel/panel-visionox-vtdr6130.c   |  9 -----
>  16 files changed, 206 deletions(-)

In response to the cover letter [1], I proposed landing patches #1-#3
directly from here while we resolve the issues talked about in
response to patch #4 [2]. I didn't hear any complaints, so I took
Linus W's review tag from the cover letter and pushed this to
drm-misc-next.

f8c37b88092e drm/panel: Don't store+check prepared/enabled for simple cases

[1] https://lore.kernel.org/r/CAD=FV=UFuUsrrZmkL8_RL5WLvkJryDwRSAy_PWTa-hX_p0dF+Q@mail.gmail.com
[2] https://lore.kernel.org/r/20230804140605.RFC.4.I930069a32baab6faf46d6b234f89613b5cec0f14@changeid/