linux-kernel - Re: [PATCH] vfio/pds: Using pci_physfn() to fix a compilation issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230913125815.3ef654e6.alex.williamson@redhat.com>
Date:   Wed, 13 Sep 2023 12:58:15 -0600
From:   Alex Williamson <alex.williamson@...hat.com>
To:     Jason Gunthorpe <jgg@...pe.ca>
Cc:     "Tian, Kevin" <kevin.tian@...el.com>,
        oushixiong <oushixiong@...inos.cn>,
        Yishai Hadas <yishaih@...dia.com>,
        Shameer Kolothum <shameerali.kolothum.thodi@...wei.com>,
        Brett Creeley <brett.creeley@....com>,
        "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] vfio/pds: Using pci_physfn() to fix a compilation issue

On Mon, 11 Sep 2023 09:28:02 -0300
Jason Gunthorpe <jgg@...pe.ca> wrote:

> On Mon, Sep 11, 2023 at 08:25:18AM +0000, Tian, Kevin wrote:
> > > From: oushixiong <oushixiong@...inos.cn>
> > > Sent: Monday, September 11, 2023 4:08 PM
> > > 
> > > From: Shixiong Ou <oushixiong@...inos.cn>
> > > 
> > > If PCI_ATS isn't set, then pdev->physfn is not defined.
> > > it causes a compilation issue:
> > > 
> > > ../drivers/vfio/pci/pds/vfio_dev.c:165:30: error: ‘struct pci_dev’ has no
> > > member named ‘physfn’; did you mean ‘is_physfn’?
> > >   165 |   __func__, pci_dev_id(pdev->physfn), pci_id, vf_id,
> > >       |                              ^~~~~~
> > > 
> > > So using pci_physfn() rather than using pdev->physfn directly.
> > > 
> > > Signed-off-by: Shixiong Ou <oushixiong@...inos.cn>  
> > 
> > Reviewed-by: Kevin Tian <kevin.tian@...el.com>  
> 
> Yes, we should do both patches

Sure, but it's sloppy to put both in with the same commit log.  Should
we change this one to something like:

    vfio/pds: Use proper PF device access helper

    The pci_physfn() helper exists to support cases where the physfn
    field may not be compiled into the pci_dev structure.  We've
    declared this driver dependent on PCI_IOV to avoid this problem,
    but regardless we should follow the precedent not to access this
    field directly.

Thanks,
Alex